Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encode: ensure symbols properly escaped during encoding if necessary #3

Closed
AnnaShaleva opened this issue Sep 15, 2021 · 1 comment
Closed

encode: ensure symbols properly escaped during encoding if necessary #3

AnnaShaleva opened this issue Sep 15, 2021 · 1 comment
Labels
enhancement Improving existing functionality I1 High impact S4 Routine U4 Nothing urgent

Comments

@AnnaShaleva
Copy link
Member

After #1 to avoid future state diff bugs we need to:

  1. Escape ASCII control characters (see https://www.w3schools.com/charsets/ref_html_ascii.asp), because they are escaped by the reference implementation. See also Fix encoder neo-project/neo#2050 thread.
  2. Ensure that utf8.RuneError case matches the C# one (currently lowercase is used in go-ordered-json).
  3. Ensure that other symbols are properly escaped if necessary.
@roman-khimov roman-khimov added enhancement Improving existing functionality U4 Nothing urgent S4 Routine I1 High impact labels Dec 20, 2023
@AnnaShaleva
Copy link
Member Author

Ref. #7, ref. #4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improving existing functionality I1 High impact S4 Routine U4 Nothing urgent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roman-khimov @AnnaShaleva