Fixed bug for work dirs longer than 255 characters, fixes #2061 #3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prioux
force-pushed
the
fix_255_chars_dirs
branch
from
83a1536 to
ec43408
Compare
This change is fully backwards compatible and will not affect existing pipelines, but it will prevent the pipeline engine from crashing when some parameters are long and it was trying to create subdirectories longer than 255 characters (a typical unix limit).
prioux
force-pushed
the
fix_255_chars_dirs
branch
from
ec43408 to
99aad8a
Compare
Codecov Report
@@ Coverage Diff @@
## master #3495 +/- ##
==========================================
+ Coverage 63.62% 65.31% +1.69%
==========================================
Files 309 309
Lines 40855 40965 +110
Branches 5379 5384 +5
==========================================
+ Hits 25995 26758 +763
+ Misses 13835 13134 -701
- Partials 1025 1073 +48
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
As suggested by @effigies
effigies
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change is fully backwards compatible and will
not affect existing pipelines, but it will prevent
the pipeline engine from crashing when some parameters
are long and it was trying to create subdirectories
longer than 255 characters (a typical unix limit).
Fixes #2061 .