-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maximum filename length #2061
Comments
@jokedurnez - do you set this config option to false by any chance?
the default value is true and by default it should have turned that long parameterization to a hash. |
@satra that option should be set to |
@mgxd - thank you. @jokedurnez - i stand corrected. to prevent the error you are receiving you can do:
|
Cool, thanks ! |
btw this didn't work for me. |
@jokedurnez - do you have node object that crashes? if so can you please inspect it to see if the config is set correctly?
was this run with current nipype? (although that particular feature has been around for a while). |
@jokedurnez is this still a problem? If so, can you try clearing your working directory? |
I changed my pipeline so that it loops over the iterables to circumvent the problem. I'll try the proposed solution later to verify. |
closing - feel free to reopen |
The section about config file and parameterize_dirs disappeared from the recent nipype documentation at https://nipype.readthedocs.io. Is it deprecated now? |
I think there was a push to deduplicate with https://miykael.github.io/nipype_tutorial/. See: https://miykael.github.io/nipype_tutorial/notebooks/basic_execution_configuration.html |
Would you ever consider setting parameterize_dirs to false as a default in nipype? We are working on integrating MRIQC into CBRAIN (http://www.cbrain.ca/), and have run into an issue with file name lengths. While the solution posted above should hopefully work for this version of MRIQC, having this changed in nipype's defaults would make it so we don't have to implement this change in future containerized versions of MRIQC + limit the likelihood of this happening for other pipelines we work with. I would understand if there are negative repercussions of this change that would outweigh the potential utility. Thanks! |
* Fixed bug for work dirs longer than 255 characters This change is fully backwards compatible and will not affect existing pipelines, but it will prevent the pipeline engine from crashing when some parameters are long and it was trying to create subdirectories longer than 255 characters (a typical unix limit).
This code runs without problem:
(note that you can reproduce the full analysis if you change the name of the nifti in the first line to one that exists on a local machine)
When I make the first two lines into an iterable, like the following, the problem appears.
This is the error trace:
I think because this outputdir exceeds the maximum number of characters in a file/folder name.
See the following, where I cut off the following directory name (not full path) at 255 characters in the second try:
I'm going to solve it by manually looping instead of using the iterables, but I thought you'd want to know. I'm not going to try to solve this, looks too deep in the nipype code, but maybe it would be better to use a random string for the iter folder instead?
The text was updated successfully, but these errors were encountered: