Skip to content

RF: Use looseversion package instead of vendoring #3477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nipype/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
import os

# XXX Deprecate this import
from .external.version import LooseVersion
from looseversion import LooseVersion

from .info import URL as __url__, STATUS as __status__, __version__
from .utils.config import NipypeConfig
Expand Down
35 changes: 0 additions & 35 deletions nipype/external/tests/test_version.py

This file was deleted.

240 changes: 0 additions & 240 deletions nipype/external/version.py

This file was deleted.

1 change: 1 addition & 0 deletions nipype/info.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ def get_nipype_gitversion():
"traits>=%s,!=5.0" % TRAITS_MIN_VERSION,
"filelock>=3.0.0",
"etelemetry>=0.2.0",
"looseversion",
]

TESTS_REQUIRES = [
Expand Down
2 changes: 1 addition & 1 deletion nipype/interfaces/dipy/preprocess.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import nibabel as nb
import numpy as np

from nipype.external.version import LooseVersion
from looseversion import LooseVersion
from ... import logging
from ..base import traits, TraitedSpec, File, isdefined
from .base import (
Expand Down
2 changes: 1 addition & 1 deletion nipype/interfaces/dipy/reconstruction.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

import numpy as np
import nibabel as nb
from nipype.external.version import LooseVersion
from looseversion import LooseVersion

from ... import logging
from ..base import TraitedSpec, File, traits, isdefined
Expand Down
2 changes: 1 addition & 1 deletion nipype/interfaces/dipy/registration.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from nipype.external.version import LooseVersion
from looseversion import LooseVersion
from ... import logging
from .base import HAVE_DIPY, dipy_version, dipy_to_nipype_interface, get_dipy_workflows

Expand Down
2 changes: 1 addition & 1 deletion nipype/interfaces/dipy/stats.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from nipype.external.version import LooseVersion
from looseversion import LooseVersion
from ... import logging
from .base import HAVE_DIPY, dipy_version, dipy_to_nipype_interface, get_dipy_workflows

Expand Down
2 changes: 1 addition & 1 deletion nipype/interfaces/dipy/tracks.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import os.path as op
import numpy as np
import nibabel as nb
from nipype.external.version import LooseVersion
from looseversion import LooseVersion

from ... import logging
from ..base import TraitedSpec, BaseInterfaceInputSpec, File, isdefined, traits
Expand Down
2 changes: 1 addition & 1 deletion nipype/utils/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
import errno
import atexit
from warnings import warn
from nipype.external.version import LooseVersion
from looseversion import LooseVersion
import configparser
import numpy as np

Expand Down
2 changes: 1 addition & 1 deletion nipype/utils/misc.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from collections.abc import Iterator
from warnings import warn

from nipype.external.version import LooseVersion
from looseversion import LooseVersion

import numpy as np

Expand Down