Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Use looseversion package instead of vendoring #3477

Merged
merged 1 commit into from
May 16, 2022

Conversation

effigies
Copy link
Member

Closes #3468.

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #3477 (8557831) into master (b410d08) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3477   +/-   ##
=======================================
  Coverage   65.25%   65.25%           
=======================================
  Files         309      309           
  Lines       40838    40838           
  Branches     5376     5376           
=======================================
  Hits        26647    26647           
  Misses      13117    13117           
  Partials     1074     1074           
Flag Coverage Δ
unittests 65.02% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nipype/info.py 87.30% <ø> (ø)
nipype/__init__.py 53.19% <100.00%> (ø)
nipype/interfaces/dipy/preprocess.py 25.42% <100.00%> (ø)
nipype/interfaces/dipy/reconstruction.py 30.69% <100.00%> (ø)
nipype/interfaces/dipy/registration.py 83.33% <100.00%> (ø)
nipype/interfaces/dipy/stats.py 83.33% <100.00%> (ø)
nipype/interfaces/dipy/tracks.py 29.60% <100.00%> (ø)
nipype/utils/config.py 63.24% <100.00%> (ø)
nipype/utils/misc.py 78.98% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b410d08...8557831. Read the comment docs.

@effigies effigies force-pushed the mnt/looseversion_pkg branch from 68fec40 to 8557831 Compare May 16, 2022 18:51
@effigies effigies merged commit 2f5d636 into nipy:master May 16, 2022
@effigies effigies deleted the mnt/looseversion_pkg branch May 16, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use separate LooseVersion package?
2 participants