Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: guard against importing ConsoleDriverModule without forRoot #12

Conversation

LayZeeDK
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

ConsoleDriverModule can be imported directly which does not currently make sense.

Issue Number: N/A

What is the new behavior?

Consumers must import using ConsoleDriverModule.forRoot.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Rebase after merging #11 as its commits are included in this one to use the test suite for ConsoleDriverModule while refactoring and adding this feature.

@LayZeeDK LayZeeDK force-pushed the LayZeeDK/feat/guard-against-importing-consoledrivermodule-without-forroot branch 2 times, most recently from 6ee0e51 to cc3f833 Compare September 28, 2020 06:14
Copy link
Contributor

@NachoVazquez NachoVazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please check the failing build and resolve the conflicts?

@LayZeeDK LayZeeDK force-pushed the LayZeeDK/feat/guard-against-importing-consoledrivermodule-without-forroot branch from cc3f833 to 64df5cb Compare September 28, 2020 18:08
@LayZeeDK LayZeeDK force-pushed the LayZeeDK/feat/guard-against-importing-consoledrivermodule-without-forroot branch from 64df5cb to 1c868ac Compare September 28, 2020 18:30
@NachoVazquez NachoVazquez merged commit a39c01c into ngworker:master Sep 28, 2020
@LayZeeDK LayZeeDK deleted the LayZeeDK/feat/guard-against-importing-consoledrivermodule-without-forroot branch September 28, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants