Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use valid default config in ConsoleDriverModule.forRoot #11

Conversation

LayZeeDK
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

An empty object is used as the default LogDriverConfig when no configuration is passed to the ConsoleDriverModule.forRoot method. An empty object does not property implement the LogDriverConfig interface as a levels property is required even though it can be undefined.

Issue Number: N/A

What is the new behavior?

The defaultLogDriverConfig is used when no configuration is passed to the ConsoleDriverModule.forRoot method.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

A test suite for the ConsoleDriverModule was added.

@NachoVazquez NachoVazquez merged commit 57965e2 into ngworker:master Sep 28, 2020
@LayZeeDK LayZeeDK deleted the LayZeeDK/fix/consoledrivermodule-forroot-use-valid-default-config branch September 28, 2020 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants