Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show empty content only when there is nothing to show #9256

Closed
wants to merge 1 commit into from

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Apr 4, 2023

☑️ Resolves

Adapt to component changes requested by designers in nextcloud-libraries/nextcloud-vue#3852

Now the panel is visible when there is an error in addition to when there are resources

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added 3. to review feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents labels Apr 4, 2023
@Pytal Pytal added this to the 💙 Next Major (27) milestone Apr 4, 2023
@Pytal Pytal self-assigned this Apr 4, 2023
@Pytal
Copy link
Member Author

Pytal commented Apr 4, 2023

/backport to stable26

@nickvergessen
Copy link
Member

This looks like a wrong approach to me. The problem is that the error occurs, not that it is shown.

Also as you can see it removes the "No shared items" which is not what we want.

@nickvergessen
Copy link
Member

The actual problem comes from:

Bildschirmfoto vom 2023-04-05 10-10-02

There is an error, but nothing in the logs. So also telling the user to contact the administration is not the right thing to do.

@nickvergessen nickvergessen marked this pull request as draft April 5, 2023 09:55
@nickvergessen
Copy link
Member

Let's start with finding out what is going on:
nextcloud/related_resources#206

Unluckily I didn't check what the issue was when taking above screenshot and it seems to not always happen

@nickvergessen
Copy link
Member

The actual error to fix is at nextcloud/related_resources#207

@nickvergessen nickvergessen deleted the fix/shared-items-empty branch June 2, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants