Display related resources error message in panel #3852
Conversation
Pytal
commented
Mar 3, 2023
•
Pytal
commented
| Screenshot | |
|---|---|
| Before (Top-right toast + empty panel area) |   |
| After |  |
Pytal
requested review from
jancborchardt,
ArtificialOwl,
artonge and
nimishavijay
Pytal
added
the
feature: related resources panel
This comment was marked as outdated.
This comment was marked as outdated.
src/components/NcRelatedResourcesPanel/NcRelatedResourcesPanel.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Great idea, the notification is also distracting every time it appears. 2 points from my side:
- Using a note card component seems like it draws a lot of attention. Could we use plain text and an icon?
- Is there any action that can be taken to rectify or explain this error? Like a "More info" link or "Try again" button?
Pytal
force-pushed
the
enh/resources-error
branch
from
24edeff to
49a0185
Compare
Pytal
changed the title
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
enh/resources-error
branch
from
49a0185 to
4e9d20f
Compare
Changed to just plain text! Without an icon though as it looks kinda strange due to the indentation and spacing :)
The error would probably be too technical for users so I added the line |
|
@nimishavijay @jancborchardt any additional design suggestions? |
|
Looks good to me! ccing @jancborchardt to double check the wording :) |
Pytal
added
4. to release
|
|
||
| description() { | ||
| if (this.error) { | ||
| return t('Error getting related resources. Please contact your system administrator if you have any questions.') |
There was a problem hiding this comment.
From my side of things this is not correct. When the 400 error occurs with Talks 1-1 chats there is nothing I as sysadmin was able to do about it.
There was a problem hiding this comment.
Then instead would it make sense to trigger a reload in the background @Pytal? Or what is usually the reason here?
There was a problem hiding this comment.
Further details in the comments over there: nextcloud/spreed#9256 (comment)
Now that logging is added it actually makes sense, but i find it weird that the error is not using the normal showError anymore
