Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPv6 to “localhost” regex (#440) #4862

Merged
merged 1 commit into from
May 15, 2017
Merged

Add IPv6 to “localhost” regex (#440) #4862

merged 1 commit into from
May 15, 2017

Conversation

coderkun
Copy link
Contributor

@coderkun coderkun commented May 14, 2017

Add the IPv6 (::1) to the regex for “localhost”

Fix #440

Signed-off-by: Oliver Hanraths <olli@coderkun.de>
@mention-bot
Copy link

@coderkun, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @tanghus and @nickvergessen to be potential reviewers.

@codecov
Copy link

codecov bot commented May 14, 2017

Codecov Report

Merging #4862 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4862      +/-   ##
============================================
+ Coverage     54.18%   54.18%   +<.01%     
  Complexity    22155    22155              
============================================
  Files          1363     1363              
  Lines         84842    84842              
  Branches       1322     1322              
============================================
+ Hits          45969    45971       +2     
+ Misses        38873    38871       -2
Impacted Files Coverage Δ Complexity Δ
lib/private/AppFramework/Http/Request.php 86.81% <ø> (ø) 147 <0> (ø) ⬇️
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 73.64% <0%> (+0.24%) 133% <0%> (ø) ⬇️
apps/comments/lib/EventHandler.php 87.5% <0%> (+8.33%) 7% <0%> (ø) ⬇️

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Thanks a lot!

@nickvergessen
Copy link
Member

Only usage is "can set trusted domain" and it is necessary there, so good.

@nickvergessen nickvergessen merged commit c56c981 into nextcloud:master May 15, 2017
@MorrisJobke MorrisJobke added this to the Nextcloud 12.0 milestone May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants