Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OC\AppFramework\Http\Request::REGEX_LOCALHOST does not match IPv6 localhost #440

Closed
ChristophWurst opened this issue Jul 18, 2016 · 2 comments
Labels

Comments

@ChristophWurst
Copy link
Member

Found in #436 (comment), not sure if this is really an issue, I didn't test it. See

const REGEX_LOCALHOST = '/^(127\.0\.0\.1|localhost)$/';

cc @MorrisJobke

@coderkun
Copy link
Contributor

coderkun commented May 14, 2017

The regex with added IPv6 localhost would look like

/^(127\.0\.0\.1|localhost|::1)$/

@MorrisJobke
Copy link
Member

@coderkun Could I ask you to open a Pull Request with this change applied? That would be awesome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants