Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add related resources panel to board sharing tab sidebar #4000

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Aug 26, 2022

@juliusknorr
Copy link
Member

vue lib bump is pending in #3991

@juliusknorr
Copy link
Member

The backend provider itself is the same as from the old projects feature or is it currently still in the related resource app?

@Pytal
Copy link
Member Author

Pytal commented Aug 26, 2022

The backend provider itself is the same as from the old projects feature or is it currently still in the related resource app?

The provider is https://github.com/nextcloud/related_resources/blob/cffb809b22c425aeeb6b88df2bd145722f94fe54/lib/RelatedResourceProviders/DeckRelatedResourceProvider.php in the related resources app

@Pytal
Copy link
Member Author

Pytal commented Sep 10, 2022

This will need @nextcloud/vue >=7.0.0-beta.1 on top of #4016

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@juliusknorr
Copy link
Member

@Pytal @ArtificialOwl Any quick and easy way to test how this looks? I tried to share the board and files to the same user but cannot get any related resources to display.

@juliusknorr
Copy link
Member

Rebased on top of the merged vue components bump

@ArtificialOwl
Copy link
Member

@Pytal @ArtificialOwl Any quick and easy way to test how this looks? I tried to share the board and files to the same user but cannot get any related resources to display.

Might be a cache issue ?

do you have something when sharing 2 different files to the same user or group ?

@juliusknorr
Copy link
Member

Yes, seems to work now without further action, just by waiting a bit

@juliusknorr juliusknorr marked this pull request as ready for review September 21, 2022 16:38
@juliusknorr juliusknorr merged commit 982b867 into master Sep 21, 2022
@juliusknorr juliusknorr deleted the enh/related-resources branch September 21, 2022 16:38
@ArtificialOwl
Copy link
Member

Yeah, so caching. do you generate an event on share creation/deletion so that the RelatedResources app can better manage the cache ?

nextcloud/related_resources#46

@juliusknorr
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants