Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add related resources panel to all places with "Add to a project" #4

Closed
5 of 7 tasks
Pytal opened this issue Aug 20, 2022 · 4 comments
Closed
5 of 7 tasks

Add related resources panel to all places with "Add to a project" #4

Pytal opened this issue Aug 20, 2022 · 4 comments
Assignees
Labels
3. to review Waiting for reviews enhancement New feature request

Comments

@Pytal
Copy link
Member

Pytal commented Aug 20, 2022

Not needed
  • deck: card detail popup (only Deck boards are linked against currently)
    private function convertToRelatedResource(DeckShare $share): IRelatedResource {
    $related = new RelatedResource(self::PROVIDER_ID, (string)$share->getBoardId());
    $related->setTitle($share->getBoardName());
    $related->setSubtitle('Deck board');
    $related->setTooltip('Deck board \'' . $share->getBoardName() . '\'');
    $related->setUrl(
    $this->urlGenerator->linkToRouteAbsolute('deck.page.index') . '#/board/' . $share->getBoardId()
    );
    $related->setMetaInt(RelatedResource::ITEM_LAST_UPDATE, $share->getLastModified());
    $kws = preg_split('/[\/_\-. ]/', ltrim(strtolower($share->getBoardName()), '/'));
    if (is_array($kws)) {
    $related->setMetaArray(RelatedResource::ITEM_KEYWORDS, $kws);
    }
    return $related;
    }
@Pytal Pytal added 2. developing Work in progress enhancement New feature request labels Aug 20, 2022
@Pytal Pytal self-assigned this Aug 20, 2022
@Pytal
Copy link
Member Author

Pytal commented Aug 26, 2022

image

I see there is already a Resources tab in the event sidebar, what would be a good place for the related resources panel in the Calendar app @ChristophWurst @st3iny?

Example panel in the Talk sidebar
image

@jancborchardt
Copy link
Member

@Pytal actually not really sure, it would fit more into "Details", especially since "Attachments" is there as well. But then the whole section is a bit much.

Maybe it’s better to move the current "Resources" to the event details, and move the "Attachments" as well as "Related resources" (both of which are Files / Media / etc) to a separate "Media" tab.

Then there would be 3 tabs still: Details, Attendees, Media.

@PVince81
Copy link
Member

should be finishable now with the 7.1.0 final bump of nextcloud-vue

@Pytal Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 6, 2022
@AndyScherzinger AndyScherzinger moved this to 🏗️ In progress in 📁 Files team Aug 3, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📁 Files team Jan 17, 2024
@AndyScherzinger
Copy link
Member

open calendar aspect will be addressed via the projects work, so the item is considered completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature request
Projects
Archived in project
Development

No branches or pull requests

4 participants