Cache getSharedWith() result #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtificialOwl
force-pushed
the
enh/noid/cache-share-request
branch
2 times, most recently
from
8450e17 to
55b21aa
Compare
ArtificialOwl
force-pushed
the
enh/noid/cache-share-request
branch
from
55b21aa to
bbc52d3
Compare
Codecov Report
@@ Coverage Diff @@
## master #972 +/- ##
===========================================
- Coverage 0.69% 0.69% -0.01%
- Complexity 5708 5716 +8
===========================================
Files 289 289
Lines 19740 19763 +23
===========================================
Hits 138 138
- Misses 19602 19625 +23
Continue to review full report at Codecov.
|
ArtificialOwl
force-pushed
the
enh/noid/cache-share-request
branch
from
bbc52d3 to
46b0f4f
Compare
Signed-off-by: Maxence Lange <maxence@artificial-owl.com> Co-authored-by: Carl Schwan <carl@carlschwan.eu>
ArtificialOwl
force-pushed
the
enh/noid/cache-share-request
branch
from
50e0018 to
15d81a6
Compare
|
squashed |
|
Caching the shares also caches the file metadata of the root of the share. Breaking sync as the old etag will be reported after a change for the duration of the cache ttl. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to cache the result from getSharedWith() which can be requested multiple times (at least 4) when loading a new page on Files App.
Each cache is identified by a key based on:
0Probeobject.The cache related to the singleId of the membership is reset when membership is updated.
All the cache is clear when creating/editing/deleting a share. (It might be interesting to filter the memberships affected by the share)