Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Synchronization is unreliable when sharing a group folder to a Team (circles) #49126

Open
4 of 8 tasks
mgallien opened this issue Nov 7, 2024 · 6 comments
Open
4 of 8 tasks
Assignees
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 29-feedback bug

Comments

@mgallien
Copy link
Contributor

mgallien commented Nov 7, 2024

⚠️ This issue respects the following points: ⚠️

Bug description

Changes are not visible by the desktop files client when syncing as an user receiving a group folders shared via a Team (i.e. circles) in view-only mode.
Etag are not propagated on changes made by the sharing user to the group folder.

Steps to reproduce

  1. Create a group folder test
  2. Create an user group group and assign user1 to it
  3. Assign full access to test group folder to user group group
  4. Create a Team called viewTeam as userA and add userB into it
  5. As userA, share group folder to \viewTeam` in view only mode
  6. Setup desktop files client for user userB and sync
  7. As userA do changes to group folder group
  8. As userB sync them
  9. As userB see the changes in web UI

Expected behavior

The expected behavior would be that userB immediately sees the updated state of any items related to group group folder.
One can see the bug in web UI as the modification time of teh top folder of group group folder is visibly not updated in web UI when refreshing the page after userA did changes.

Nextcloud Server version

29

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.3

Web server

Apache (supported)

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@mgallien mgallien added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Nov 7, 2024
@mgallien mgallien changed the title [Bug]: Synchornization is unreliable when sharing a group folder to a Team (circles) [Bug]: Synchronization is unreliable when sharing a group folder to a Team (circles) Nov 7, 2024
@icewind1991
Copy link
Member

Interestingly, occ info:file ... does show the correct, updated, etag. But dav shows a different one...

@icewind1991
Copy link
Member

Something seems to be caching the metadata, setting the configured caches to NullCache resolves the issue.

@icewind1991
Copy link
Member

nextcloud/circles#972 added the caching for circle shares

@ArtificialOwl
Copy link
Member

yes, but the save() method is called and reset the cache when generating a new share on a groupfolder

@icewind1991
Copy link
Member

icewind1991 commented Nov 7, 2024

The issue isn't when creating a new share, it's when editing files inside the share. The share recipient will see the old metadata for the root of the share for the cache duration

@ArtificialOwl
Copy link
Member

Oh. got it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 29-feedback bug
Projects
None yet
Development

No branches or pull requests

4 participants