Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcBreadcrumbs): improve the breadcrumbs shrinking behaviour #5069

Merged
merged 1 commit into from
Jan 15, 2024
+14 −7
Merged

fix(NcBreadcrumbs): improve the breadcrumbs shrinking behaviour #5069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/NcBreadcrumb/NcBreadcrumb.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,8 +284,8 @@ export default {
padding: 0;

&:last-child {
max-width: 210px;
font-weight: bold;
min-width: 0;

// Don't show breadcrumb separator for last crumb
.vue-crumb__separator {
Expand Down Expand Up @@ -340,6 +340,7 @@ export default {

.button-vue {
padding: 0 4px 0 16px;
max-width: 100%;

&__wrapper {
flex-direction: row-reverse;
Expand Down
18 changes: 12 additions & 6 deletions src/components/NcBreadcrumbs/NcBreadcrumbs.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ is dropped on a creadcrumb.
<NcBreadcrumb name="Folder 4"
title="Folder 4"
href="/Folder 1/Folder 2/Folder 3/Folder 4" />
<NcBreadcrumb name="Folder 5"
<NcBreadcrumb name="Folder 5 with an overflowing long name"
title="Folder 5"
href="/Folder 1/Folder 2/Folder 3/Folder 4/Folder 5"
:disable-drop="true">
Expand Down Expand Up @@ -293,7 +293,7 @@ export default {
// We hide elements alternating to the left and right
const currentIndex = startIndex + ((i % 2) ? i + 1 : i) / 2 * Math.pow(-1, i + (nrCrumbs % 2))
// Calculate the remaining overflow width after hiding this breadcrumb
overflow -= this.getWidth(breadcrumbs[currentIndex]?.elm)
overflow -= this.getWidth(breadcrumbs[currentIndex]?.elm, currentIndex === (breadcrumbs.length - 1))
hiddenIndices.push(currentIndex)
i++
}
Expand Down Expand Up @@ -330,24 +330,31 @@ export default {
* @return {number} The total width
*/
getTotalWidth(breadcrumbs) {
return breadcrumbs.reduce((width, crumb, index) => width + this.getWidth(crumb?.elm), 0)
return breadcrumbs.reduce((width, crumb, index) => width + this.getWidth(crumb?.elm, index === (breadcrumbs.length - 1)), 0)
},
/**
* Calculates the width of the provided element
*
* @param {object} el The element
* @param {boolean} isLast Is this the last crumb
* @return {number} The width
*/
getWidth(el) {
getWidth(el, isLast) {
if (!el?.classList) return 0
const hide = el.classList.contains(`${crumbClass}--hidden`)
el.style.minWidth = 'auto'
// For the last crumb, we calculate with a max-width of 210px,
// but don't set it in CSS to allow it to grow.
if (isLast) {
el.style.maxWidth = '210px'
}
el.classList.remove(`${crumbClass}--hidden`)
const w = el.offsetWidth
if (hide) {
el.classList.add(`${crumbClass}--hidden`)
}
el.style.minWidth = ''
el.style.maxWidth = ''
return w
},
/**
Expand Down Expand Up @@ -654,9 +661,8 @@ export default {
display: inline-flex;
align-items: center;

&--collapsed :deep(.vue-crumb:last-child) {
&--collapsed :deep(.vue-crumb:last-child) {
min-width: 100px;
flex-shrink: 1;
}

nav {
Expand Down
Loading