fix(NcBreadcrumbs): improve the breadcrumbs shrinking behaviour #5069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
added
the
feature: breadcrumbs
raimund-schluessler
force-pushed
the
fix/noid/breadcrumbs-shrinking
branch
from
3e72a2e to
dd8cd67
Compare
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
force-pushed
the
fix/noid/breadcrumbs-shrinking
branch
from
dd8cd67 to
fcbaeaf
Compare
raimund-schluessler
added
bug
raimund-schluessler
requested review from
jancborchardt,
susnux,
skjnldsv,
Pytal,
ShGKme and
nimishavijay
skjnldsv
approved these changes
Jan 15, 2024
susnux
approved these changes
Jan 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
This PR fixes a bug and improves the shrinking behavior of
NcBreadcrumbs.In case the last crumb has actions, the crumb would overflow and not ellipsise:
Improved shrinking behavior:
The last crumb now uses all the available space before ellipsising the text. If not enough space is available, it shrinks until it is 210px wide, then the first crumb will be hidden. The freed space will then be used again by the last crumb. The
min-width: 210px;is the same width as before.🏚️ Before (discrete jumps and unused white-space on the right):
Bildschirmaufzeichnung.vom.2024-01-14.21-29-57.webm
🏡 After (continuous shrinking and no unused space, last crumb extends as needed and possible):
Bildschirmaufzeichnung.vom.2024-01-14.21-28-42.webm