Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New api 4.0.1 #21

Merged
merged 5 commits into from
Sep 8, 2017
Merged

New api 4.0.1 #21

merged 5 commits into from
Sep 8, 2017

Conversation

napsternxg
Copy link
Owner

This change uses the new API which has the backend and frontend code
separate. The code is now in three parts:

Other changes:

Fixes #4, #11, #14, #15, #16

This change uses the new API which has the backend and frontend code
seperate. The code is now in three parts:
- core.js: has all the basic api code.
- background.js: uses API to create a background app.
- popup.js: uses API to create frontend app.

All changes happen by using a call back to the storage sync functions.

Other changes:
- Keyboard shortcut is Ctrl + Shift + L
- Updated manifest
- package.json added
- Linter profile added

Fixes #4, #11, #14, #15, #16
- Better way to get filtered list of items for UI. Fixes #16
- Add title to list items. Fixes #19
- Add some license details and headers to each of the files. Fixes #20
- Allow download as JSON. Fixes #13
- Make the title smaller on the popup. Saves space.
* Updated manifest.json
* Removed useless files.
* Cleaned up code using linter.
* Updated README
@kav2k
Copy link
Contributor

kav2k commented Sep 8, 2017

I'm sorry, but have you tested it yourself?

You pushed out a broken update, 4.0.1 is nonfunctional.

I said I'd test it if I have time, but I haven't claimed I did by now:

the code is (presumably) working now
I'll do a testing run. If able, that is - I'll be quite busy until the end of next week.

@kav2k
Copy link
Contributor

kav2k commented Sep 8, 2017

My apologies; I overreacted to this issue (due to misinterpreting what the error was).

4.0.1 was functional, but old data ("count") was causing trouble. It wouldn't be trivial to catch in testing.

@napsternxg
Copy link
Owner Author

No worries. The current version is 4.0.3 and works on my machine which has count, mix of old links without timestamp and new links with timestamp. In future, I wish to include a function which does some cleaning of the storage on the update of the API and removes these inconsistencies. That would require some work so I will leave of for later.

@kav2k
Copy link
Contributor

kav2k commented Sep 8, 2017

I would recommend keeping the storage schema version in the storage, that removes the need for heuristics when you change the data format.

@napsternxg napsternxg restored the new-api branch September 8, 2017 20:52
@napsternxg napsternxg deleted the new-api branch September 8, 2017 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants