Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Linting profile #17

Closed
napsternxg opened this issue Sep 6, 2017 · 1 comment
Closed

Add Linting profile #17

napsternxg opened this issue Sep 6, 2017 · 1 comment
Labels
enhancement
Milestone
Release 4.0.1

Comments

@napsternxg
Copy link
Owner

Add ESLint profile to the code as suggested by @kav2k
@napsternxg napsternxg modified the milestone: Release 4.0.1 Sep 8, 2017
@napsternxg napsternxg mentioned this issue Sep 8, 2017
Merged
napsternxg added a commit that referenced this issue Sep 8, 2017
@napsternxg
Merge pull request #21 from napsternxg/new-api
440b1c4 
New api 4.0.1

This change uses the new API which has the backend and frontend code
separate. The code is now in three parts:
- core.js: has all the basic api code.
- background.js: uses API to create a background app.
- popup.js: uses API to create frontend app.
- All changes happen by using a call back to the storage sync functions.
- Fixes #15 and Fixes #16 

Other changes:
- Keyboard shortcut is Ctrl + Shift + L. Fixes #4 
- Updated manifest. Fixes #8 
- package.json added 
- Linter profile added. Fixes #17  

Fixes #4, #11, #14, #15, #16


- Better way to get filtered list of items for UI. Fixes #16
- Add title to list items. Fixes #19
- Add some license details and headers to each of the files. Fixes #20
- Allow download as JSON. Fixes #13
- Make the title smaller on the popup. Saves space.
- Updated manifest.json
- Removed useless files.
- Cleaned up code using linter.
- Updated README
@kav2k
Copy link
Contributor

kav2k commented Sep 8, 2017

Well you did a linter profile.. but it's:

  1. Incomplete/broken (without env settings, it does not recognize ES6, for instance).
  2. Code isn't actually linted according to the provided rules.

In addition, I must say that Google preset is very rigid and pretty far from your current code's state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Release 4.0.1
Development

No branches or pull requests
2 participants
@napsternxg @kav2k