Improve error text for other always on apps

[Rawa]

---

This change is 

[linear]

DROID-1857 Improve error text for Android 12 and above when we are unable to get vpn permission

[mullmat]

Reviewable status: 0 of 25 files reviewed, 1 unresolved discussion

---

android/lib/resource/src/main/res/values/strings.xml line 119 at r1 (raw file):

    <string name="set_dns_error">Unable to set system DNS server. Please send a problem report.</string>
    <string name="start_tunnel_error">Unable to start tunnel connection. Please send a problem report.</string>
    <string name="vpn_permission_denied_error">VPN permission was denied when creating the tunnel. Ensure no other always-on vpn app are active and then try connecting again.</string>

VPN permission was denied or another app has "Always-on VPN" enabled.

Code quote:

VPN permission was denied when creating the tunnel. Ensure no other always-on vpn app are active and then try connecting again.

[mullmat]

Reviewed 23 of 25 files at r1, 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)

[Rawa]

Reviewable status: complete! all files reviewed, all discussions resolved

---

android/lib/resource/src/main/res/values/strings.xml line 119 at r1 (raw file):

Previously, mullmat (MullMat) wrote…

VPN permission was denied or another app has "Always-on VPN" enabled.

Fixed!

[mullmat]

very nice 👍

[Pururun]

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion

---

android/lib/common/src/main/kotlin/net/mullvad/mullvadvpn/lib/common/util/ContextExtensions.kt line 29 at r3 (raw file):

fun Context.resolveAlwaysOnVpnPackageName(): String? =
    try {
        Settings.Secure.getString(contentResolver, ALWAYS_ON_VPN_APP)

Nit: Can't we version gate this, since we know that it will always fail on Android 12+?

[Rawa]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)

---

android/lib/common/src/main/kotlin/net/mullvad/mullvadvpn/lib/common/util/ContextExtensions.kt line 29 at r3 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

Nit: Can't we version gate this, since we know that it will always fail on Android 12+?

We could, if we don't care about debug builds showing the correct always on app. I'll ask for a second opinion if we should gate it.

[Pururun]

Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved