Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Link Netlify in the danger comment #6513

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Oct 14, 2022

Same as mui/material-ui#34688, a small time saver. See ⬇️

Screenshot 2022-10-14 at 23 36 02

@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Oct 14, 2022
@oliviertassinari oliviertassinari marked this pull request as ready for review October 14, 2022 21:29
@mui-bot
Copy link

mui-bot commented Oct 14, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-6513--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 515.5 915 847.9 743.3 171.115
Sort 100k rows ms 651.8 1,279.9 1,279.9 1,028.7 216.389
Select 100k rows ms 198.6 291.8 260.3 250.94 31.385
Deselect 100k rows ms 139 298.2 216 228.14 59.212

Generated by 🚫 dangerJS against 0bad31a

@oliviertassinari oliviertassinari merged commit e195e5a into mui:next Oct 19, 2022
@oliviertassinari oliviertassinari deleted the link-netlify branch October 19, 2022 11:30
m4theushw added a commit to m4theushw/mui-x that referenced this pull request Oct 20, 2022
commit 634aabe
Author: Matheus Wichman <matheushw@outlook.com>
Date:   Wed Oct 19 20:26:54 2022 -0300

    Update migration guide

commit 40bbeef
Merge: d49de67 4fbb67d
Author: Matheus Wichman <matheushw@outlook.com>
Date:   Wed Oct 19 11:07:48 2022 -0300

    Merge branch 'next' into rename-selection-props

commit 4fbb67d
Author: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
Date:   Wed Oct 19 15:26:21 2022 +0300

    [test] Remove BrowserStack (mui#6263)

commit fff240b
Author: Olivier Tassinari <olivier.tassinari@gmail.com>
Date:   Wed Oct 19 14:18:46 2022 +0200

    [core] Fix trailing spaces and git diff format (mui#6523)

    Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>

commit 4488896
Author: Olivier Tassinari <olivier.tassinari@gmail.com>
Date:   Wed Oct 19 13:37:09 2022 +0200

    [core] Improve the playground DX (mui#6514)

commit e195e5a
Author: Olivier Tassinari <olivier.tassinari@gmail.com>
Date:   Wed Oct 19 13:30:12 2022 +0200

    [core] Link Netlify in the danger comment (mui#6513)

commit a4fedc1
Author: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Date:   Wed Oct 19 11:57:42 2022 +0200

    [adapters] Fix localisation of the placeholder (mui#6547)

commit d49de67
Author: Matheus Wichman <matheushw@outlook.com>
Date:   Tue Oct 18 19:17:48 2022 -0300

    [DataGrid] Rename selection props
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants