[core] Link Netlify in the danger comment #34688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oliviertassinari
force-pushed
the
link-netlify
branch
from
46ab7bb to
2e54d27
Compare
|
I'm merging, I expect this to be a noncontroversial change. We can always revert if it causes trouble. |
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might be simpler than having to click on the Netlify status to find the preview URL. For the community, it might even make the difference between trying the preview out and not knowing it exists.
An alternative would be to enable this comment back (easy):
netlify/open-api#394 (comment). However, for maintainers that aren't using emails to manage their GitHub notifications, this would create even more noise than
mui-botalready creates (with the email you can create a filter to delete the mui-bot & Netlify comment notification). Netlify's native comment also uses more vertical space.