Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGridPro] Add list view tests #15043

Merged
merged 6 commits into from
Oct 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 98 additions & 0 deletions packages/x-data-grid-pro/src/tests/listView.DataGridPro.test.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,98 @@
import * as React from 'react';
import { expect } from 'chai';
import { createRenderer, screen } from '@mui/internal-test-utils';
import {
DataGridPro,
DataGridProProps,
GridColDef,
GridListColDef,
GridRowsProp,
} from '@mui/x-data-grid-pro';

const rows: GridRowsProp = [{ id: '123567', title: 'test' }];

const columns: GridColDef[] = [{ field: 'id' }, { field: 'title' }];

const listColumn: GridListColDef = {
field: 'listColumn',
renderCell: (params) => <div data-testid="list-column">Title: {params.row.title}</div>,
};

describe('<DataGridPro /> - List view', () => {
const { render } = createRenderer();

function Test(props: Partial<DataGridProProps>) {
return (
<div style={{ width: 300, height: 300 }}>
<DataGridPro columns={columns} rows={rows} {...props} />
</div>
);
}

it('should not render list column when list view is not enabled', () => {
render(
<div style={{ width: 300, height: 300 }}>
<DataGridPro columns={columns} rows={rows} unstable_listColumn={listColumn} />
</div>,
);
expect(screen.queryByTestId('list-column')).to.equal(null);
});

it('should render list column when list view is enabled', () => {
render(
<div style={{ width: 300, height: 300 }}>
<DataGridPro
columns={columns}
rows={rows}
unstable_listView
unstable_listColumn={listColumn}
/>
</div>,
);
expect(screen.getByTestId('list-column')).not.to.equal(null);
expect(screen.getByTestId('list-column')).to.have.text('Title: test');
});

it('should render list column when `unstable_listView` prop updates', () => {
const { setProps } = render(<Test unstable_listColumn={listColumn} />);
expect(screen.queryByTestId('list-column')).to.equal(null);

setProps({ unstable_listView: true });

expect(screen.getByTestId('list-column')).not.to.equal(null);
expect(screen.getByTestId('list-column')).to.have.text('Title: test');

setProps({ unstable_listView: false });

expect(screen.queryByTestId('list-column')).to.equal(null);
});

it('should update cell contents when the `renderCell` function changes', () => {
const { setProps } = render(<Test unstable_listView unstable_listColumn={listColumn} />);

setProps({
unstable_listColumn: {
...listColumn,
renderCell: (params) => <div data-testid="list-column">ID: {params.row.id}</div>,
},
} as Partial<DataGridProProps>);

expect(screen.getByTestId('list-column')).to.have.text('ID: 123567');
});

it('should warn if the `unstable_listColumn` prop is not provided when `unstable_listView` is enabled', () => {
expect(() => {
render(
<div style={{ width: 300, height: 300 }}>
<DataGridPro columns={columns} rows={rows} unstable_listView />
</div>,
);
}).toWarnDev(
[
'MUI X: The `unstable_listColumn` prop must be set if `unstable_listView` is enabled.',
'To fix, pass a column definition to the `unstable_listColumn` prop, e.g. `{ field: "example", renderCell: (params) => <div>{params.row.id}</div> }`.',
'For more details, see https://mui.com/x/react-data-grid/list-view/',
].join('\n'),
);
});
});
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import * as React from 'react';
import { warnOnce } from '@mui/x-internals/warning';
import type { GridListColDef } from '../../../models/colDef/gridColDef';
import { GridStateInitializer } from '../../utils/useGridInitializeState';
import { GridPrivateApiCommunity } from '../../../models/api/gridApiCommunity';
Expand All @@ -13,12 +14,14 @@ export const listViewStateInitializer: GridStateInitializer<
Pick<DataGridProcessedProps, 'unstable_listColumn'>
> = (state, props, apiRef) => ({
...state,
listViewColumn: { ...props.unstable_listColumn, computedWidth: getListColumnWidth(apiRef) },
listViewColumn: props.unstable_listColumn
? { ...props.unstable_listColumn, computedWidth: getListColumnWidth(apiRef) }
: undefined,
});

export function useGridListView(
apiRef: React.MutableRefObject<GridPrivateApiCommunity>,
props: Pick<DataGridProcessedProps, 'unstable_listColumn'>,
props: Pick<DataGridProcessedProps, 'unstable_listView' | 'unstable_listColumn'>,
) {
/*
* EVENTS
Expand Down Expand Up @@ -68,6 +71,16 @@ export function useGridListView(
});
}
}, [apiRef, props.unstable_listColumn]);

React.useEffect(() => {
if (props.unstable_listView && !props.unstable_listColumn) {
warnOnce([
'MUI X: The `unstable_listColumn` prop must be set if `unstable_listView` is enabled.',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo:

  • Link to the docs
  • Perhaps show a very basic example

'To fix, pass a column definition to the `unstable_listColumn` prop, e.g. `{ field: "example", renderCell: (params) => <div>{params.row.id}</div> }`.',
'For more details, see https://mui.com/x/react-data-grid/list-view/',
]);
}
}, [props.unstable_listView, props.unstable_listColumn]);
}

function getListColumnWidth(apiRef: React.MutableRefObject<GridPrivateApiCommunity>) {
Expand Down
Loading