Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGridPro] Add list view tests #15043

Merged
merged 6 commits into from
Oct 29, 2024
Merged

Conversation

KenanYusuf
Copy link
Member

@KenanYusuf KenanYusuf commented Oct 21, 2024

Closes #14995

@KenanYusuf KenanYusuf added test component: data grid This is the name of the generic UI component, not the React module! feature: List view Related to the data grid liist view feature labels Oct 21, 2024
@mui-bot
Copy link

mui-bot commented Oct 21, 2024

Deploy preview: https://deploy-preview-15043--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against f56d35b

@KenanYusuf KenanYusuf marked this pull request as draft October 21, 2024 15:07
@KenanYusuf KenanYusuf marked this pull request as ready for review October 21, 2024 15:53
React.useEffect(() => {
if (props.unstable_listView && !props.unstable_listColumn) {
warnOnce(
'MUI X: The `unstable_listColumn` prop must be set if `unstable_listView` is enabled.',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo:

  • Link to the docs
  • Perhaps show a very basic example

@KenanYusuf KenanYusuf added the needs cherry-pick The PR should be cherry-picked to master after merge label Oct 29, 2024
@KenanYusuf KenanYusuf merged commit 8ed5c99 into mui:master Oct 29, 2024
20 checks passed
@KenanYusuf KenanYusuf deleted the list-view-tests branch October 29, 2024 13:41
github-actions bot pushed a commit that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! feature: List view Related to the data grid liist view feature needs cherry-pick The PR should be cherry-picked to master after merge test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[data grid] Add tests for the list view feature
3 participants