-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pickers] Fix to transform-origin
when popper opens to top
#10069
[pickers] Fix to transform-origin
when popper opens to top
#10069
Conversation
Netlify deploy previewNetlify deploy preview: https://deploy-preview-10069--material-ui-x.netlify.app/ Updated pagesNo updates. These are the results for the performance tests:
|
packages/x-date-pickers/src/internals/components/PickersPopper.tsx
Outdated
Show resolved
Hide resolved
Awesome, it feels clearly better 👍 To be fair, in #5490 (comment), I have made the case for much less frequently flipping the popup to be shown on the top. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice improvement! 🎉
Yes, those are great two points that could be explored separately from one another.
|
Fixes #10006
The placement is
top-start
when the popper opens to the top, because of that the conditional style did not work.Preview: https://deploy-preview-10069--material-ui-x.netlify.app/x/react-date-pickers/