-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pickers] Open animation origin bug when reversed #10006
Comments
Are we sure that this can be considered a bug?
In regards to the transition speed: isn't it a matter of the |
@LukasTy I agree with you that the position of the popper is correct in HEAD. I'm flagging the animation transformation origin that is wrong https://developer.mozilla.org/en-US/docs/Web/CSS/transform-origin.
In this context, the Popper is only responsible for the position, so no. The Grow and Fade are lower primitives, maybe but not sure. I actually think it would be great to replace them with pure CSS. I have seen cases where they slow things down.
I think it's possible to customize it but the problem is with the default behavior. Now, I think that the Date Picker and Autocomplete, Select, Data Grid panels should use the same higher level abstraction. The Select uses Popover which could be that abstraction, but we need to rewrite it from scratch. cc @michaldudak who worked a bit on this recently. |
Steps to reproduce 🕹
Link to live example:
Steps:
Current behavior 😯
Screen.Recording.2023-08-11.at.18.48.36.mov
Expected behavior 🤔
https://mui.com/material-ui/react-select/#with-a-dialog
Screen.Recording.2023-08-11.at.18.49.35.mov
We have another example in https://mui.com/material-ui/react-menu/#menulist-composition that might help with the implementation.
Context 🔦
I have noticed answering #9781 (comment).
It's also related to the design review I had on Joy UI in https://www.notion.so/mui-org/Olivier-design-review-on-Joy-Design-3ada9a7bcfa44b9fab1fe5032dfb33bb?pvs=4#fae949292c7a4eabacd2a377ba13cc86. Are we sure about the current animation? It doesn't feel great on my end. When you go to https://mui.com/x/react-date-pickers/#overview and click on the button, you have to wait for the open animation to complete. However, when you go to https://vercel.com/design/calendar or https://ui.shadcn.com/docs/components/date-picker, the animation is shorter, it feels clearly more responsive.
Your environment 🌎
v6.11.1
Order ID or Support key 💳 (optional)
No response
The text was updated successfully, but these errors were encountered: