-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Try alternative to OverrideComponent
type (ver 2)
#33964
Closed
mnajdova
wants to merge
12
commits into
mui:master
from
mnajdova:feat/overridable-component-improvements-2
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5007238
[core] Add `CompoenntWithComponentProp` type
mnajdova 0752787
Make the CI happy
mnajdova 7ecd73c
Fix lint issue
mnajdova 8870553
Replace the existing OverridableComponent for testing perf
mnajdova 3870e8e
cleanup rest of the card content updated leftovers
mnajdova 28e5b51
Update docs/data/material/pagesApi.js
mnajdova 5d4f616
Fix lint
mnajdova cace4e4
Merge branch 'feat/overridable-component-improvements' of https://git…
mnajdova 278c3fe
Merge branch 'master' into feat/overridable-component-improvements
mnajdova 4123794
Merge branch 'master' into feat/overridable-component-improvements
mnajdova b8cd37f
Try alternative implementation
mnajdova 7f3dc26
prettier
mnajdova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,7 @@ interface MyOverrideProps { | |
myString?: string; | ||
myCallback?(n: number): void; | ||
} | ||
declare const MyOverrideComponent: React.ComponentType<MyOverrideProps>; | ||
declare const MyOverrideComponent: React.FunctionComponent<MyOverrideProps>; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Needs to be double checked, for some reason I needed to change the type from |
||
class MyOverrideClassComponent extends React.Component<MyOverrideProps> { | ||
render() { | ||
return null; | ||
|
@@ -16,7 +16,7 @@ class MyOverrideClassComponent extends React.Component<MyOverrideProps> { | |
const MyOverrideRefForwardingComponent = React.forwardRef<HTMLLegendElement>((props, ref) => ( | ||
<div ref={ref} /> | ||
)); | ||
declare const MyIncompatibleComponent1: React.ComponentType<{ inconsistentProp?: number }>; | ||
declare const MyIncompatibleComponent1: React.FunctionComponent<{ inconsistentProp?: number }>; | ||
|
||
declare const Foo: OverridableComponent<{ | ||
props: { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's interesting that in both implementations these ts-ignores are required.