[core] Try alternative to OverrideComponent type (ver 2)
#33964
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hub.com/mnajdova/material-ui into feat/overridable-component-improvements
mnajdova
commented
Aug 17, 2022
| @@ -7,7 +7,7 @@ interface MyOverrideProps { | |||
| myString?: string; | |||
| myCallback?(n: number): void; | |||
| } | |||
| declare const MyOverrideComponent: React.ComponentType<MyOverrideProps>; | |||
| declare const MyOverrideComponent: React.FunctionComponent<MyOverrideProps>; | |||
There was a problem hiding this comment.
Needs to be double checked, for some reason I needed to change the type from ComponentType to FunctionComponent.
mnajdova
commented
Aug 17, 2022
| @@ -106,10 +106,12 @@ const Link = React.forwardRef<HTMLAnchorElement, LinkProps>(function Link(props, | |||
| const nextjsProps = { to: href, linkAs, replace, scroll, shallow, prefetch, locale }; | |||
|
|
|||
| if (noLinkStyle) { | |||
| // @ts-ignore TODO: this needs to be resolved | |||
There was a problem hiding this comment.
It's interesting that in both implementations these ts-ignores are required.
|
I am closing it turned out to be a dead end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative of #32735. Inspired by https://github.com/radix-ui/primitives/blob/2f139a832ba0cdfd445c937ebf63c2e79e0ef7ed/packages/react/polymorphic/src/polymorphic.ts
Can't really see some notable difference:
master:
PR:
