Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed commit format verification prompt for Windows users #561

Merged
merged 6 commits into from
Oct 10, 2016
Merged

fix: Fixed commit format verification prompt for Windows users #561

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7af29a6
fix: Fixed commit format verification prompt for Windows users
berraknil Oct 8, 2016
6ab0d7c
feat: Support using a proxy to access the signing API
berraknil Oct 9, 2016
9642332
fix: revert changes
berraknil Oct 9, 2016
8ee2743
fix: Fixed commit format verification prompt for Windows users
berraknil Oct 10, 2016
2e8161c
Merge branch 'master' of https://github.com/berraknil/web-ext
berraknil Oct 10, 2016
0c5cf78
fix: Fixed commit format verification prompt for Windows users
berraknil Oct 10, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@
"firefox-client": "0.3.0",
"flow-bin": "0.33.0",
"git-hooks": "1.1.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this. I just tried it on Mac and it works just fine with only the git-hooks-win package.

"git-hooks-win": "1.1.11",
Copy link
Contributor

@kumar303 kumar303 Oct 8, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! This looks really promising and it sounds like it will also work on Mac. However, since the installation of this module installs a hook script, I think we also need to remove the old git-hooks dependency, right? Otherwise both of them will be modifying the hook script.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I didn't want to mess with the original package since I don't have a mac to try if this one works properly on Mac too. If it does we should remove the other one and keep the windows compatible ,otherwise I'll try one of the few other solutions I looked into (like grunt-git-hooks) which are a bit more complicated.

"grunt": "1.0.1",
"grunt-contrib-clean": "1.0.0",
"grunt-contrib-copy": "1.0.0",
Expand Down