fix: Fixed commit format verification prompt for Windows users #561
Conversation
| @@ -87,6 +87,7 @@ | |||
| "firefox-client": "0.3.0", | |||
| "flow-bin": "0.33.0", | |||
| "git-hooks": "1.1.1", | |||
| "git-hooks-win": "1.1.11", | |||
There was a problem hiding this comment.
Good find! This looks really promising and it sounds like it will also work on Mac. However, since the installation of this module installs a hook script, I think we also need to remove the old git-hooks dependency, right? Otherwise both of them will be modifying the hook script.
There was a problem hiding this comment.
Good point, I didn't want to mess with the original package since I don't have a mac to try if this one works properly on Mac too. If it does we should remove the other one and keep the windows compatible ,otherwise I'll try one of the few other solutions I looked into (like grunt-git-hooks) which are a bit more complicated.
There was a problem hiding this comment.
This is working great on Mac so I think this solution will be cross platform. Excellent!
Can you also remove this caveat about Windows in the contributor guide? https://github.com/mozilla/web-ext/blob/master/CONTRIBUTING.md#checking-commit-message-formatting
| @@ -87,6 +87,7 @@ | |||
| "firefox-client": "0.3.0", | |||
| "flow-bin": "0.33.0", | |||
| "git-hooks": "1.1.1", | |||
There was a problem hiding this comment.
We can remove this. I just tried it on Mac and it works just fine with only the git-hooks-win package.
|
Hi Berrak, thanks for the fix, and welcome! I've added this fix to our recognition page. |
Fixes #551
Added the git-hooks-win package to package.json under developer dependencies. This package has zero dependencies and supports the current model of format verification prompt that is available to Mac OS users for Windows users as well.
This was the error message I got before adding the package
And after installing the package, prompt works correctly
Tested on Windows 10.