fix: fx notify #544
Merged
fix: fx notify #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vijayg10
requested review from
mdebarros,
elnyry-sam-k,
oderayi,
bushjames,
kleyow and
geka-evk
as code owners
|
geka-evk
reviewed
Oct 8, 2024
|
|
||
| let payloadForFXP = JSON.parse(payload) | ||
| if (payloadForFXP.fulfilment) { | ||
| delete payloadForFXP.fulfilment |
There was a problem hiding this comment.
It's a bit unclear for me, why we need to delete fulfilment from payloadForFXP
There was a problem hiding this comment.
HI @geka-evk as per the spec, there is no fulfilment in the patch notification.
There was a problem hiding this comment.
kleyow
approved these changes
Oct 8, 2024
kleyow
added a commit
that referenced
this pull request
Dec 6, 2024
* feat(mojaloop/#3574): added fxTransfers endpoints (#517) * feat(3574): added fxTransfers endpoints * feat(3574): added new prom metrics for fxTransfers; added PUT fxTransfers error callback endpoint * feat(3574): added unit-tests * feat(3574): fixed PR comments; updated fxTransfer error endpoint * feat(3574): fixed PR comments * feat(3574): added fx-abort action * feat(3574): fixed payload error message * feat(3574): fixed PUT /fxTransfers payload schema * feat(3574): fixed PUT /fxTransfers fulfilMessageDto * feat(3574): updated notification handler to deal with FX transfers (#518) * fix: notification handler * feat(3574): used new central-services-shared snapshot * feat(3574): modified Participant.getEndpoint (#519) * feat(3574): modified Participant.getEndpoint * feat(3574): small reformatting * feat: updated deps * chore(snapshot): 14.1.0-snapshot.0 * fix: disable ci snapshot * chore(snapshot): 14.1.0-snapshot.1 * fix: disable ci snapshot2 * chore(snapshot): 14.1.0-snapshot.2 * fix: fspiop headers * chore(snapshot): 14.1.0-snapshot.3 * chore(snapshot): 14.1.0-snapshot.4 * chore: update central shared lib * chore(snapshot): 14.1.0-snapshot.5 * feat(3574): added notificationMessageDto; small reformatting; added unit-tests (#520) Co-authored-by: Steven Oderayi <oderayi@gmail.com> * feat(mojaloop/#3656): fx hardening (#522) * feat: enable sending events directly to Kafka (#527) * chore(snapshot): 14.1.0-snapshot.6 * fix: image scan * fix: image scan * fix: prune indeed * fix: bad date validation * chore(snapshot): 14.1.0-snapshot.7 * chore(snapshot): 14.1.0-snapshot.8 * chore(snapshot): 14.1.0-snapshot.9 * chore(snapshot): 14.1.0-snapshot.10 * chore(snapshot): 14.1.0-snapshot.11 * test: increase integration tests timeout * chore(snapshot): 14.1.0-snapshot.12 * fix: remove version * feat(csi-164): paramteize switch id (#531) * feat: proxy (#533) * feat(mojaloop/csi-190): add notification case for forwarded errors (#535) * feat: add notification case for forwarded errors * add tests * test * lint * fix test * test: add proxy await * feat(csi-334): updated proxyCache to use redis cluster (#536) * feat(csi-334): updated proxyCache to use redis cluster * feat(csi-334): updated proxyCache to use redis cluster * feat(csi-334): updated proxyCache to use redis cluster * feat(csi-334): updated proxyCache to use redis cluster * chore(snapshot): 14.1.0-snapshot.0 * chore(snapshot): 14.1.0-snapshot.1 * chore(snapshot): 14.1.0-snapshot.2 * chore(snapshot): 14.1.0-snapshot.3 * chore(snapshot): 14.1.0-snapshot.4 * chore(snapshot): 14.1.0-snapshot.5 * chore(snapshot): 14.1.0-snapshot.6 * chore(snapshot): 14.1.0-snapshot.7 * chore(snapshot): 14.1.0-snapshot.8 * chore(snapshot): 14.1.0-snapshot.9 * chore(snapshot): 14.1.0-snapshot.10 * chore(snapshot): 14.1.0-snapshot.11 * chore(snapshot): 14.1.0-snapshot.12 * chore(snapshot): 14.1.0-snapshot.13 * chore(snapshot): 14.1.0-snapshot.14 * chore(snapshot): 14.1.0-snapshot.15 * chore(snapshot): 14.1.0-snapshot.16 * chore(snapshot): 14.1.0-snapshot.17 * feat(csi-541): updated proxyCache to use redis cluster (#537) * feat(csi-541): updated proxyCache to use redis cluster * feat(csi-541): updated proxyCache to use redis cluster * feat(csi-541): updated proxyCache to use redis cluster * chore(snapshot): 14.1.0-snapshot.18 * fix: fixed fx reserver handling in notification handler (#538) * fix: fixed fx reserver handling in notification handler * test: update int test * test: disable test * test: update int test * ci: update int test harness --------- Co-authored-by: Steven Oderayi <oderayi@gmail.com> * fix(csi-555): improved logging (#539) * fix(csi-555): improved logging * fix(csi-555): improved logging * chore(snapshot): 14.1.0-snapshot.19 * feat(csi/551): produce fx-forwarded message on proxied fxTransfer (#540) * feat(csi/551): produce fx-forwarded message on proxied fxTransfer * add notification for fx-forwarded errors * test(csi/551): add integration test for fx-forwarded message (#541) * int tests * dep update * fix: ci * feat(csi/643): add fx-notify forwarding (#542) * feat(csi/643): add fx-notify forwarding * audit * int tests * tests * command * chore: update deps * feat: add ULID support (#543) * fix: uuid/ulid regex * test: fix integration tests * test: fix integration tests * fix: fx notify (#544) * fix: fx notify * fix: lint * fix: refactor * fix: lint * fix: refactor * fix: int tests * fix: content type * chore(snapshot): 14.1.0-snapshot.24 * chore(snapshot): 14.1.0-snapshot.25 * fix: decouple notifications (#545) * test: start using mojaloop/build orb (#547) * fix: sonar security hot spots * chore: address fx-impl comments (#562) * chore: add header files * chore: remove unneeded todos * chore: fix tests * deps * chore: update license --------- Co-authored-by: Eugen Klymniuk <keramet.kh@gmail.com> Co-authored-by: geka.evk <geka.evk@gmail.com> Co-authored-by: Vijay <vijaya.guthi@infitx.com> Co-authored-by: Steven Oderayi <oderayi@gmail.com> Co-authored-by: Kalin Krustev <kalin.krustev@gmail.com> Co-authored-by: vijayg10 <33152110+vijayg10@users.noreply.github.com>
kleyow
added a commit
that referenced
this pull request
Jan 18, 2025
* feat(mojaloop/#3574): added fxTransfers endpoints (#517) * feat(3574): added fxTransfers endpoints * feat(3574): added new prom metrics for fxTransfers; added PUT fxTransfers error callback endpoint * feat(3574): added unit-tests * feat(3574): fixed PR comments; updated fxTransfer error endpoint * feat(3574): fixed PR comments * feat(3574): added fx-abort action * feat(3574): fixed payload error message * feat(3574): fixed PUT /fxTransfers payload schema * feat(3574): fixed PUT /fxTransfers fulfilMessageDto * feat(3574): updated notification handler to deal with FX transfers (#518) * fix: notification handler * feat(3574): used new central-services-shared snapshot * feat(3574): modified Participant.getEndpoint (#519) * feat(3574): modified Participant.getEndpoint * feat(3574): small reformatting * feat: updated deps * chore(snapshot): 14.1.0-snapshot.0 * fix: disable ci snapshot * chore(snapshot): 14.1.0-snapshot.1 * fix: disable ci snapshot2 * chore(snapshot): 14.1.0-snapshot.2 * fix: fspiop headers * chore(snapshot): 14.1.0-snapshot.3 * chore(snapshot): 14.1.0-snapshot.4 * chore: update central shared lib * chore(snapshot): 14.1.0-snapshot.5 * feat(3574): added notificationMessageDto; small reformatting; added unit-tests (#520) Co-authored-by: Steven Oderayi <oderayi@gmail.com> * feat(mojaloop/#3656): fx hardening (#522) * feat: enable sending events directly to Kafka (#527) * chore(snapshot): 14.1.0-snapshot.6 * fix: image scan * fix: image scan * fix: prune indeed * fix: bad date validation * chore(snapshot): 14.1.0-snapshot.7 * chore(snapshot): 14.1.0-snapshot.8 * chore(snapshot): 14.1.0-snapshot.9 * chore(snapshot): 14.1.0-snapshot.10 * chore(snapshot): 14.1.0-snapshot.11 * test: increase integration tests timeout * chore(snapshot): 14.1.0-snapshot.12 * fix: remove version * feat(csi-164): paramteize switch id (#531) * feat: proxy (#533) * feat(mojaloop/csi-190): add notification case for forwarded errors (#535) * feat: add notification case for forwarded errors * add tests * test * lint * fix test * test: add proxy await * feat(csi-334): updated proxyCache to use redis cluster (#536) * feat(csi-334): updated proxyCache to use redis cluster * feat(csi-334): updated proxyCache to use redis cluster * feat(csi-334): updated proxyCache to use redis cluster * feat(csi-334): updated proxyCache to use redis cluster * chore(snapshot): 14.1.0-snapshot.0 * chore(snapshot): 14.1.0-snapshot.1 * chore(snapshot): 14.1.0-snapshot.2 * chore(snapshot): 14.1.0-snapshot.3 * chore(snapshot): 14.1.0-snapshot.4 * chore(snapshot): 14.1.0-snapshot.5 * chore(snapshot): 14.1.0-snapshot.6 * chore(snapshot): 14.1.0-snapshot.7 * chore(snapshot): 14.1.0-snapshot.8 * chore(snapshot): 14.1.0-snapshot.9 * chore(snapshot): 14.1.0-snapshot.10 * chore(snapshot): 14.1.0-snapshot.11 * chore(snapshot): 14.1.0-snapshot.12 * chore(snapshot): 14.1.0-snapshot.13 * chore(snapshot): 14.1.0-snapshot.14 * chore(snapshot): 14.1.0-snapshot.15 * chore(snapshot): 14.1.0-snapshot.16 * chore(snapshot): 14.1.0-snapshot.17 * feat(csi-541): updated proxyCache to use redis cluster (#537) * feat(csi-541): updated proxyCache to use redis cluster * feat(csi-541): updated proxyCache to use redis cluster * feat(csi-541): updated proxyCache to use redis cluster * chore(snapshot): 14.1.0-snapshot.18 * fix: fixed fx reserver handling in notification handler (#538) * fix: fixed fx reserver handling in notification handler * test: update int test * test: disable test * test: update int test * ci: update int test harness --------- Co-authored-by: Steven Oderayi <oderayi@gmail.com> * fix(csi-555): improved logging (#539) * fix(csi-555): improved logging * fix(csi-555): improved logging * chore(snapshot): 14.1.0-snapshot.19 * feat(csi/551): produce fx-forwarded message on proxied fxTransfer (#540) * feat(csi/551): produce fx-forwarded message on proxied fxTransfer * add notification for fx-forwarded errors * test(csi/551): add integration test for fx-forwarded message (#541) * int tests * dep update * fix: ci * feat(csi/643): add fx-notify forwarding (#542) * feat(csi/643): add fx-notify forwarding * audit * int tests * tests * command * chore: update deps * feat: add ULID support (#543) * fix: uuid/ulid regex * test: fix integration tests * test: fix integration tests * fix: fx notify (#544) * fix: fx notify * fix: lint * fix: refactor * fix: lint * fix: refactor * fix: int tests * fix: content type * chore(snapshot): 14.1.0-snapshot.24 * chore(snapshot): 14.1.0-snapshot.25 * fix: decouple notifications (#545) * test: start using mojaloop/build orb (#547) * chore(release): [ci skip] 14.1.0-iso.0 * chore: version * chore(release): [ci skip] 14.2.0-iso.1 * chore: continuous deployment * chore(release): [ci skip] 14.2.0-iso.2 * chore: continuous deployment * chore(release): [ci skip] 14.2.0-iso.3 * feat(csi/108): replace joi, add interface switching and initial iso support (#546) * chore(release): [ci skip] 14.2.0-iso.5 * fix: iso follow-up fixes (#551) * chore(release): [ci skip] 14.2.0-iso.6 * chore: update iso api spec (#552) * chore: update iso api spec * chore: update iso api spec * chore: format date * chore(release): [ci skip] 14.2.0-iso.7 * fix: fix reserve sending back original iso payload (#553) * chore(release): [ci skip] 14.2.0-iso.8 * chore: fix reserved aborted message (#556) * chore: fix fspiop regression * chore(release): [ci skip] 14.2.0-iso.9 * fix(csi-884): forward proxied error callbacks unmodified to fix JWS "invalid signature" bug (#557) * chore(release): [ci skip] 14.2.0-iso.10 * chore: update deps (#559) * chore(release): [ci skip] 14.2.0-iso.11 * fix: error forwarding (#560) * chore(release): [ci skip] 14.2.0-iso.12 * chore: use the central-services-metrics plugin (#561) * chore(release): [ci skip] 14.2.0-iso.13 * chore: update dependencies * chore(release): [ci skip] 14.2.0-iso.14 * chore: use the central-services-metrics plugin * chore: use the central-services-metrics plugin * chore: use the central-services-metrics plugin * chore(release): [ci skip] 14.2.0-iso.15 * chore: update dependencies * chore(release): [ci skip] 14.2.0-iso.16 * chore: update dependencies * chore(release): [ci skip] 14.2.0-iso.17 * fix: fx abort callback (#563) * feat: correctly generate fx-abort headers * test: fix coverage * chore(release): [ci skip] 14.2.0-iso.18 * chore: merge main * chore: remove joi * Fix code scanning alert no. 7: Prototype-polluting function Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * chore(release): [ci skip] 15.1.0-iso.0 * chore: audit test * chore(release): [ci skip] 15.1.0-iso.1 * chore: address comments * chore(release): [ci skip] 15.1.0-iso.2 * fix(csi-1001): transform content-type header for switch-generated error callbacks in ISO mode (#566) * chore(release): [ci skip] 15.1.0-iso.3 * chore: bump cs-shared * chore(release): [ci skip] 15.1.0-iso.4 * chore: update deps * chore(release): [ci skip] 15.1.0-iso.5 * fix: timeout reserved error (#568) * fix: notification handler * chore: dep udpates * fix: lint * chore(release): [ci skip] 15.1.0-iso.6 * chore: bump deps (#567) * chore: remove unneeded stringify * chore: dep * chore: bump * chore(release): [ci skip] 15.1.0-iso.7 * chore: update central-services-metrics * chore(release): [ci skip] 15.1.0-iso.8 * feat(csi-927): used common loggingPlugin (#565) * feat(csi-927): used common loggingPlugin * feat(csi-927): used common loggingPlugin * chore(release): [ci skip] 15.1.0-iso.9 * fix: monorepo (#569) * chore(release): [ci skip] 15.1.0-iso.10 * chore: remove merge files and dep up * chore(release): [ci skip] 15.1.0-iso.11 * chore: conflicts * chore(release): [ci skip] 15.1.0-iso.12 * chore: licensing * chore(release): [ci skip] 15.1.0-iso.13 * chore: licensing * chore(release): [ci skip] 15.1.0-iso.14 --------- Co-authored-by: Eugen Klymniuk <keramet.kh@gmail.com> Co-authored-by: geka.evk <geka.evk@gmail.com> Co-authored-by: Vijay <vijaya.guthi@infitx.com> Co-authored-by: Steven Oderayi <oderayi@gmail.com> Co-authored-by: Kalin Krustev <kalin.krustev@gmail.com> Co-authored-by: vijayg10 <33152110+vijayg10@users.noreply.github.com> Co-authored-by: mojaloopci <info@mojaloop.io> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.