Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.06] backport fixes for max grpc message size and lint errors #2378

Merged
merged 3 commits into from
Sep 19, 2017
Merged

[17.06] backport fixes for max grpc message size and lint errors #2378

merged 3 commits into from
Sep 19, 2017

Conversation

andrewhsu
Copy link
Member

@andrewhsu andrewhsu commented Sep 19, 2017 •
edited
Loading

Backport fixes from these PRs to master:

Cherry-pick commits aa2c48b and b1bcc05:

$ git cherry-pick -s -x aa2c48b b1bcc05

No conflicts.

@anshulpundir @andrewhsu
Fix linter errors.
01a610b 
Signed-off-by: Anshul Pundir <anshul.pundir@docker.com>
(cherry picked from commit aa2c48b)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
@andrewhsu andrewhsu changed the title backport fixes for max grpc message size and lint errors [17.06] backport fixes for max grpc message size and lint errors Sep 19, 2017
@andrewhsu
Copy link
Member Author

cc @anshulpundir @nishanttotla

anshulpundir and others added 2 commits September 19, 2017 12:58
@anshulpundir @andrewhsu
Set grpc max message size to 128MB. (#2375)
33690ed 
Signed-off-by: Anshul Pundir <anshul.pundir@docker.com>(cherry picked from commit b1bcc05)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
@andrewhsu
run vndr again because it now deletes unused files
790ccec 
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
@codecov
Copy link

codecov bot commented Sep 19, 2017 •
edited
Loading

Codecov Report

Merging #2378 into bump_v17.06 will increase coverage by 0.1%.
The diff coverage is 92.85%.

@@              Coverage Diff               @@
##           bump_v17.06    #2378     +/-   ##
==============================================
+ Coverage        59.66%   59.76%   +0.1%     
==============================================
  Files              120      120             
  Lines            25104    25067     -37     
==============================================
+ Hits             14978    14981      +3     
+ Misses            8787     8750     -37     
+ Partials          1339     1336      -3

@anshulpundir anshulpundir merged commit ce88f8a into moby:bump_v17.06 Sep 19, 2017
@andrewhsu andrewhsu deleted the grpc branch September 19, 2017 20:48
@vieux vieux mentioned this pull request Sep 19, 2017
Merged
@Marc3001 Marc3001 mentioned this pull request Oct 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishanttotla nishanttotla nishanttotla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewhsu @nishanttotla @anshulpundir