Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter errors. #2377

Merged
merged 1 commit into from
Sep 19, 2017
Merged

Fix linter errors. #2377

merged 1 commit into from
Sep 19, 2017

Conversation

anshulpundir
Copy link
Contributor

No description provided.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "lint" git@github.com:anshulpundir/swarmkit.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: Anshul Pundir <anshul.pundir@docker.com>
@codecov
Copy link

codecov bot commented Sep 19, 2017

Codecov Report

Merging #2377 into master will increase coverage by 0.03%.
The diff coverage is 92.3%.

@@            Coverage Diff            @@
##           master   #2377      +/-   ##
=========================================
+ Coverage   60.37%   60.4%   +0.03%     
=========================================
  Files         128     128              
  Lines       26305   26267      -38     
=========================================
- Hits        15881   15866      -15     
+ Misses       9025    9008      -17     
+ Partials     1399    1393       -6

@dperny
Copy link
Collaborator

dperny commented Sep 19, 2017

LGTM

@dperny dperny merged commit 699ef48 into moby:master Sep 19, 2017
dperny pushed a commit to dperny/swarmkit-1 that referenced this pull request Oct 23, 2017
Cherry picks moby#2377 to v17.03. Does not apply cleanly. Also involves
making changes not in the original patch, but in the spirit of that
patch.

(cherry picked from commit aa2c48b)
Signed-off-by: Drew Erny <drew.erny@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants