Attempt to make tests less flaky #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
marthacryan
commented
Mar 11, 2024
•
marthacryan
commented
- Removes a test that was testing the first step of the test that followed it (checked that if you open the import taskpane, the file we're looking for is visible. This is tested by double clicking that file in the next test).
- Changes the configure csv import test to use the toolbar to open the import taskpane rather than using the "Import files" button (which appears to be a flaky way to do it)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
naterush
reviewed
Mar 12, 2024
| @@ -137,7 +137,7 @@ jobs: | |||
| - os: 'windows-latest' | |||
| project: | |||
| test-name: webkit | |||
| - os: 'macos-latest' | |||
| - os: 'macos-13' | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.