Merge pull request #1258 from mito-ds/less-flaky

Attempt to make tests less flaky

Author: Nate Rush

mitosheet/css/mito.css

@@ -61,7 +61,7 @@
 }
 
 .mito-container {
-    height: var(--mito-height);
+    height: var(--mito-height, 538px); /* Default height */
     display: flex;
     flex-direction: column;
 

mitosheet/setup.py

@@ -135,7 +135,7 @@ def get_data_files_from_data_files_spec(
             "setuptools==56.0.0"
         ],
         'streamlit': [
-            'streamlit>=1.24',
+            'streamlit>=1.24,<1.32',
         ],
         'optional_feature_dependencies': [
             # According to this documentation (https://github.com/snowflakedb/snowflake-connector-python),

tests/extra-requirements.txt

@@ -1,2 +1,2 @@
-streamlit
+streamlit<1.32
 dash

tests/streamlit_ui_tests/taskpanes/file_import.spec.ts

@@ -1,6 +1,6 @@
 
 import { expect, test } from '@playwright/test';
-import { checkColumnCellsHaveExpectedValues, checkOpenTaskpane, clickButtonAndAwaitResponse, clickTab, getMitoFrame, getMitoFrameWithTestCSV } from '../utils';
+import { awaitResponse, checkColumnCellsHaveExpectedValues, checkOpenTaskpane, clickButtonAndAwaitResponse, clickTab, getMitoFrame, getMitoFrameWithTestCSV } from '../utils';
 
 const openImportTaskpaneAndSelectData = async (mito: any, file: string) => {
   await mito.locator('.mito-toolbar-button', { hasText: 'Import' }).click();
@@ -9,7 +9,7 @@ const openImportTaskpaneAndSelectData = async (mito: any, file: string) => {
 }
 
 test.describe('File Import Taskpane', () => {
-
+  
   test('Test import CSV file', async ({ page }) => {
     const mito = await getMitoFrameWithTestCSV(page);
     await clickTab(page, mito, 'Data');
@@ -20,8 +20,7 @@ test.describe('File Import Taskpane', () => {
 
   test('Test import CSV File with double click', async ({ page }) => {
     const mito = await getMitoFrame(page);
-    await mito.getByRole('button', { name: 'Import Files' }).click();
-    await mito.getByText('test.csv').dblclick();
+    await openImportTaskpaneAndSelectData(mito, 'test.csv')
     await expect(mito.getByTitle('Column1')).toBeVisible();
   });
 
@@ -146,7 +145,8 @@ test.describe('File Import Taskpane', () => {
     const mito = await getMitoFrame(page);
 
     // Open the configure taskpane for the csv with special delimiters
-    await mito.getByText('Import Files').click();
+    await mito.locator('.mito-toolbar-button', { hasText: 'Import' }).click();
+    await mito.locator('.mito-dropdown-item', { hasText: 'Import Files' }).click();
     await mito.getByText('semicolon-delimiter.csv').click();
     await mito.getByText('Configure').click();
 

tests/streamlit_ui_tests/utils.ts

@@ -4,7 +4,9 @@ import { FormulaType } from './types';
 
 export const getMitoFrame = async (page: Page): Promise<FrameLocator> => {
     await page.goto('http://localhost:8555/');
-    return page.frameLocator('iframe[title="mitosheet\\.streamlit\\.v1\\.spreadsheet\\.my_component"]');
+    const mito = page.frameLocator('iframe[title="mitosheet\\.streamlit\\.v1\\.spreadsheet\\.my_component"]');
+    await expect(mito.locator('.text-button:not(.text-button-disabled)', { hasText: 'Import Files' })).toBeVisible();
+    return mito;
 };
 
 export const importCSV = async (page: Page, mito: FrameLocator, filename: string): Promise<void> => {