Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browse by Domain Improvements #589

Merged
merged 15 commits into from
Jul 26, 2024

Conversation

mitchdawson1982
Copy link
Collaborator

@mitchdawson1982 mitchdawson1982 commented Jul 24, 2024

  • Implements a new ListDomainFetcher class to obtain a list of domains and the number of associated entities tagged for display in the catalogue
  • Only domains with entities tagged for display in the catalogue greater than zero are displayed in browse by domain on the home page
  • Implements listDomains.graphql to list domains with query and entity filters applied
  • Implements list_domains methods on the datahub client and search classes
  • Implements a ListDomainOption type
  • Displays the number of tagged assets associated with the given domain in the home page

@mitchdawson1982 mitchdawson1982 requested a review from a team as a code owner July 24, 2024 11:35
@mitchdawson1982 mitchdawson1982 self-assigned this Jul 24, 2024
@mitchdawson1982 mitchdawson1982 linked an issue Jul 24, 2024 that may be closed by this pull request
@mitchdawson1982 mitchdawson1982 marked this pull request as draft July 24, 2024 11:35
@mitchdawson1982 mitchdawson1982 marked this pull request as ready for review July 25, 2024 14:54
Copy link
Contributor

@LavMatt LavMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Mitch.

I think we can probably do away with the facets too, as part of that other ticket to fix search page domain filter choices, but might be worth checking in with Mat M on Monday to double check facets code isn't doing anything else (i don't think it is)

@mitchdawson1982 mitchdawson1982 merged commit 68a09af into main Jul 26, 2024
5 of 6 checks passed
@mitchdawson1982 mitchdawson1982 deleted the fmd-560-browse-by-domain-improvements branch July 26, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browse by domain improvements
2 participants