update tests and parameterise list_domains fixture

Author: mitchdawson1982

lib/datahub-client/tests/test_integration_with_datahub_server.py

@@ -31,7 +31,11 @@
     TagRef,
     UsageRestrictions,
 )
-from data_platform_catalogue.search_types import MultiSelectFilter, ResultType
+from data_platform_catalogue.search_types import (
+    ListDomainOption,
+    MultiSelectFilter,
+    ResultType,
+)
 
 jwt_token = os.environ.get("CATALOGUE_TOKEN")
 api_url = os.environ.get("CATALOGUE_URL", "")
@@ -43,6 +47,9 @@ def test_list_domains():
     client = DataHubCatalogueClient(jwt_token=jwt_token, api_url=api_url)
     response = client.list_domains()
     assert len(response) > 0
+    domain = response[0]
+    assert isinstance(domain, ListDomainOption)
+    assert "urn:li:domain" in domain.urn
 
 
 @runs_on_development_server

tests/conftest.py

@@ -297,17 +297,22 @@ def mock_catalogue(request, example_database):
             ListDomainOption(
                 urn="urn:li:domain:prisons",
                 name="Prisons",
-                total=fake.random_int(min=0, max=100),
+                total=fake.random_int(min=1, max=100),
             ),
             ListDomainOption(
                 urn="urn:li:domain:courts",
                 name="Courts",
-                total=fake.random_int(min=0, max=100),
+                total=fake.random_int(min=1, max=100),
             ),
             ListDomainOption(
                 urn="urn:li:domain:finance",
                 name="Finance",
-                total=fake.random_int(min=0, max=100),
+                total=fake.random_int(min=1, max=100),
+            ),
+            ListDomainOption(
+                urn="urn:li:domain:hq",
+                name="HQ",
+                total=0,
             ),
         ],
     )
@@ -437,8 +442,8 @@ def search_facets():
 
 
 @pytest.fixture
-def list_domains():
-    return ListDomainFetcher().fetch()
+def list_domains(filter_zero_entities):
+    return ListDomainFetcher(filter_zero_entities).fetch()
 
 
 @pytest.fixture