Edit parse properties to convert some None values to #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test Evidence before fix when searching for "xhibit_all_offence_disposal_stg": with fix: |
Signed-off-by: Helder Ribeiro <helder.ribeiro@digital.justice.gov.uk>
Signed-off-by: Helder Ribeiro <helder.ribeiro@digital.justice.gov.uk>
hjribeiro-moj
force-pushed
the
fmd-327-map-none-to-empty-str
branch
from
387dc05 to
ec4f653
Compare
hjribeiro-moj
changed the title
LavMatt
reviewed
May 15, 2024
LavMatt
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 fix for #327
parse_propertiesto look for fields requiring default of "" and convert it if filed was explicitly set toNone. Found 2 examples:descritpionandexternalUrl.