Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Some values may be null in datahub, but are non-null in our models #327

Closed
MatMoore opened this issue May 9, 2024 · 0 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@MatMoore
Copy link
Contributor

MatMoore commented May 9, 2024

Describe the bug.

https://ministryofjustice.sentry.io/issues/5321294599/?alert_rule_id=15157261&alert_type=issue&notification_uuid=ccc3a005-8ade-4aeb-8b87-c209758db688&project=4507181591101440&referrer=slack

In this case description is None, but we are validating that description is a string.

To Reproduce

No response

Expected Behaviour

Two options

  1. We change our model to match datahub
  2. Cooerce None values to string when reading from datahub. Anytime we do .get(field, "") on the graphql response we need to make sure we handle any case where the field is set, but set to None

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done ✅
Development

No branches or pull requests

2 participants