Experimental undo/redo handling for notebook multicursor #226545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
connor4312
reviewed
Aug 26, 2024
Comment on lines
+308
to
+310
| value.reverse().forEach(async element => { | ||
| await element.undo(); | ||
| }); |
There was a problem hiding this comment.
These are async, but do they need to happen in series to get executed correctly? Atm this runs all of them in parallel
There was a problem hiding this comment.
@connor4312 they don't need to since they are separate models. Though I would later make them a "transaction" to avoid issues with multiple undo/redo requests.
connor4312
approved these changes
Aug 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.