Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Notebook cmd+d multi-select typing and deleteLeft editing #226681

Closed
2 tasks done
Yoyokrazy opened this issue Aug 26, 2024 · 8 comments
Closed
2 tasks done

Test: Notebook cmd+d multi-select typing and deleteLeft editing #226681

Yoyokrazy opened this issue Aug 26, 2024 · 8 comments

Comments

@Yoyokrazy
Copy link
Contributor

Yoyokrazy commented Aug 26, 2024

Refs: #141673, #226545

Complexity: 1

author: @Yoyokrazy

Create Issue


Summary

Notebooks have multi-select that can be triggered via cmd+d

Steps to Test:

  • Go wild
  • Try to break things like:
    • decoration states
    • being in editing state without decorations
    • undo-redo stacks (if the latter ref PR merges)

Thanks for testing!

@bpasero
Copy link
Member

bpasero commented Aug 28, 2024

@Tyriar fyi somehow author got assigned to test 🤔

@bpasero bpasero removed their assignment Aug 28, 2024
@bpasero
Copy link
Member

bpasero commented Aug 28, 2024

I felt the steps could have been a bit more descriptive.

if the latter ref PR merges

What does that even mean?

@bpasero bpasero closed this as completed Aug 28, 2024
@Tyriar
Copy link
Member

Tyriar commented Aug 28, 2024

@Tyriar fyi somehow author got assigned to test 🤔

@sandy081 FYI

@Yoyokrazy
Copy link
Contributor Author

Sorry about this, assigned this tpi to the two of us manually. This was primarily to selfhost and track issues before pushing it to the entire team, so no bug with assignment actually happened. Sorry about having to interpret my half-written thoughts @bpasero 😅

@sandy081
Copy link
Member

I have thought so that you assigned it to yourself for a reason. Hence, I also believe that it makes sense to allow assigning the author self explicitly to the test plan item.

@Tyriar
Copy link
Member

Tyriar commented Aug 28, 2024

👍 I've also done this once or twice in the past to give myself some dedicated time to test a feature on a different OS to my main. It makes sense in special circumstances.

We could possibly avoid this confusion if the test plan tool added (assigned self explicitly) to the user?

@sandy081
Copy link
Member

Actually, it makes sense to add such a label for all assignments, author has added explicitly

@bpasero
Copy link
Member

bpasero commented Aug 28, 2024

@Yoyokrazy oh ok, that explains a lot. sorry for acting up, now it makes sense 😄

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants
@rebornix @bpasero @Tyriar @sandy081 @Yoyokrazy and others