Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons in Accessible view don't seem right #191684

Closed
karthiknadig opened this issue Aug 29, 2023 · 5 comments · Fixed by #191723
Closed

Icons in Accessible view don't seem right #191684

karthiknadig opened this issue Aug 29, 2023 · 5 comments · Fixed by #191723
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verified Verification succeeded
Milestone

Comments

@karthiknadig
Copy link
Member

Testing #191345

image

The bell icon for manage extension does not seem correct here, gear icon might be better.
The shown next and show previous should swap places. > and < should probably be < and >
I would expect x to be at the end.

@meganrogge
Copy link
Contributor

I would expect x to be at the end.

This is at the start of the default actions by design bc it is the most important one. I'm going to change the icon from an X to something else (tracked in a different issue)

@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues polish Cleanup and polish issue labels Aug 29, 2023
@meganrogge meganrogge added this to the August 2023 milestone Aug 29, 2023
@meganrogge
Copy link
Contributor

The shown next and show previous should swap places. > and < should probably be < and >
Screenshot 2023-08-29 at 12 37 14 PM

Re the order, you'd usually want to go to the next before the previous, so I think we should leave that as is. You're not on the latest insider's FYI, the icons are now up and down arrows.

@meganrogge
Copy link
Contributor

I agree, we should use the gear for manage extension.

@meganrogge
Copy link
Contributor

Verify that if a notification has "Manage Extension", it uses a gear icon in the accessible view.

@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 29, 2023
@karthiknadig
Copy link
Member Author

karthiknadig commented Aug 30, 2023

image

Verified that the gear icon is for configuring. It looks like we are re-using the bell(slash) icon for disable accessible view hint. That same icon is used for Do not disturb. @daviddossett should this be a different icon?
EDIT: looks like this was already discussed. Ignore my comment on bell-slash

@karthiknadig karthiknadig added the verified Verification succeeded label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants