Cherry picking fixes into release #8032
Conversation
* Disabling new debug adapter experiments * Apply suggestions from code review for turning off debug adapter experiment
|
@kimadeline @luabud Have i missed any other fixes? |
Codecov Report
@@ Coverage Diff @@
## release #8032 +/- ##
========================================
Coverage 58.78% 58.78%
========================================
Files 496 496
Lines 22126 22126
Branches 3560 3560
========================================
Hits 13006 13006
Misses 8308 8308
Partials 812 812Continue to review full report at Codecov.
|
|
@karthiknadig 73b5937 for #7607 was merged into master but hasn't been validated yet, so I don't know whether we want to include it or not despite it being a P0. Do we need to cherry-pick DS commits too? |
|
DS is currently testing their fixes. They will be cherry-picking it into release and let me know. |
|
@rchiodo Are you guys done with fixes needed for the point release? |
@luabud What is your opinion on this. I think we should take it since the prompt is showing up on Windows. I tried this on a couple of my windows machines. I did not get a prompt. Then again I am not sure how clean they were since this fix requires a clean install. |
* Don't prompt inheritEnv on windows * Add verification for undefined workspace config * Why did i commit that formatting change
No sorry still have one more. We haven't moved our changes into release yet either. |
|
We wanted to bug bash some more. |
|
@karthiknadig yes please let's take the prompt (it's been validated now, right?) |
|
@luabud i will include the prompt fix. I am going to close this one. since one of the cherry pics had a conflict and looks like it was not merged correctly. |
No description provided.