Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use the PTVSD version in the folder name for the wheel experiment #7876

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

kimadeline
Copy link

For #7836

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@codecov-io
Copy link

codecov-io commented Oct 9, 2019

Codecov Report

Merging #7876 into master will decrease coverage by 0.67%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7876      +/-   ##
==========================================
- Coverage   59.24%   58.57%   -0.68%     
==========================================
  Files         498      498              
  Lines       22293    21932     -361     
  Branches     3580     3575       -5     
==========================================
- Hits        13208    12847     -361     
  Misses       8263     8263              
  Partials      822      822
Impacted Files Coverage Δ
...nt/datascience/jupyter/invalidNotebookFileError.ts 0% <0%> (-75%) ⬇️
.../client/datascience/jupyter/jupyterConnectError.ts 0% <0%> (-66.67%) ⬇️
...science/jupyter/jupyterKernelPromiseFailedError.ts 0% <0%> (-50%) ⬇️
...ent/datascience/jupyter/jupyterWaitForIdleError.ts 0% <0%> (-50%) ⬇️
src/client/language/characters.ts 12% <0%> (-21.34%) ⬇️
src/client/testing/codeLenses/main.ts 60% <0%> (-17.78%) ⬇️
src/client/datascience/cellFactory.ts 72.34% <0%> (-17.32%) ⬇️
src/client/constants.ts 75% <0%> (-5%) ⬇️
src/client/providers/providerUtilities.ts 84.61% <0%> (-4.28%) ⬇️
src/client/api.ts 90% <0%> (-2.86%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ac8da2...5dd4ea3. Read the comment docs.

@kimadeline kimadeline marked this pull request as ready for review October 10, 2019 15:12
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kimadeline kimadeline merged commit b6ce843 into microsoft:master Oct 10, 2019
@kimadeline kimadeline deleted the 7836-ptvsd-requirements branch October 10, 2019 21:36
karthiknadig pushed a commit to karthiknadig/vscode-python that referenced this pull request Oct 16, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants