Skip to content

Commit

Permalink
Updating connect timeout from 15 to 30 seconds (#18593)
Browse files Browse the repository at this point in the history
* Updating connect timeout from 15 to 30 seconds

* loc
  • Loading branch information
Benjin authored Feb 21, 2025
1 parent e66d65c commit b208a3b
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion localization/xliff/vscode-mssql.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -2059,7 +2059,7 @@
<source xml:lang="en">[Optional] Specify the length of time in seconds to wait for a command to execute before terminating the attempt and generating an error. The default value is 30 seconds.</source>
</trans-unit>
<trans-unit id="mssql.connection.connectTimeout">
<source xml:lang="en">[Optional] Specify the length of time in seconds to wait for a connection to the server before terminating connection attempt and generating an error. The default value is 15 seconds for on-premise and 30 seconds for Azure SQL Database connections.</source>
<source xml:lang="en">[Optional] Specify the length of time in seconds to wait for a connection to the server before terminating connection attempt and generating an error. The default value is 30 seconds.</source>
</trans-unit>
<trans-unit id="mssql.connection.maxPoolSize">
<source xml:lang="en">[Optional] Specify the maximum number of connections allowed in the pool.</source>
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -1103,7 +1103,7 @@
},
"connectTimeout": {
"type": "number",
"default": 15,
"default": 30,
"description": "%mssql.connection.connectTimeout%"
},
"commandTimeout": {
Expand Down
2 changes: 1 addition & 1 deletion package.nls.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"mssql.connection.trustServerCertificate":"[Optional] When set to 'true', the SQL Server SSL certificate is automatically trusted when the communication layer is encrypted using SSL. Set 'false' for Azure SQL Database connection.",
"mssql.connection.hostNameInCertificate":"[Optional] When specified (and encrypt=Mandatory and trustServerCertificate=false), SQL Server uses provided hostname for validating trust with the server certificate.",
"mssql.connection.persistSecurityInfo":"[Optional] When set to false, security-sensitive information, such as the password, is not returned as part of the connection if the connection is open or has ever been in an open state.",
"mssql.connection.connectTimeout":"[Optional] Specify the length of time in seconds to wait for a connection to the server before terminating connection attempt and generating an error. The default value is 15 seconds for on-premise and 30 seconds for Azure SQL Database connections.",
"mssql.connection.connectTimeout":"[Optional] Specify the length of time in seconds to wait for a connection to the server before terminating connection attempt and generating an error. The default value is 30 seconds.",
"mssql.connection.commandTimeout":"[Optional] Specify the length of time in seconds to wait for a command to execute before terminating the attempt and generating an error. The default value is 30 seconds.",
"mssql.connection.connectRetryCount":"[Optional] Specify the number of attempts to restore connection.",
"mssql.connection.connectRetryInterval":"[Optional] Specify the delay between attempts to restore connection.",
Expand Down
2 changes: 1 addition & 1 deletion src/connectionconfig/connectionDialogWebviewController.ts
Original file line number Diff line number Diff line change
Expand Up @@ -891,7 +891,7 @@ export class ConnectionDialogWebviewController extends ReactWebviewPanelControll
private async loadEmptyConnection() {
const emptyConnection = {
authenticationType: AuthenticationType.SqlLogin,
connectTimeout: 15, // seconds
connectTimeout: 30, // seconds
applicationName: "vscode-mssql",
} as IConnectionDialogProfile;
this.state.connectionProfile = emptyConnection;
Expand Down

0 comments on commit b208a3b

Please sign in to comment.