Adding missing secureEnclaves connection parameter to connection inte…

…rfaces (#18727) * adding missing secureEnclaves connection parameter * adding missing props to tests * Bumping STS version
microsoft · Feb 21, 2025 · e66d65c · e66d65c
1 parent d0c76b1
commit e66d65c
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 1 deletion.
diff --git a/src/configurations/config.json b/src/configurations/config.json
@@ -1,7 +1,7 @@
 {
   "service": {
     "downloadUrl": "https://github.com/Microsoft/sqltoolsservice/releases/download/{#version#}/microsoft.sqltools.servicelayer-{#fileName#}",
-    "version": "5.0.20250214.1",
+    "version": "5.0.20250220.4",
     "downloadFileNames": {
       "Windows_86": "win-x86-net8.0.zip",
       "Windows_64": "win-x64-net8.0.zip",

diff --git a/src/models/connectionCredentials.ts b/src/models/connectionCredentials.ts
@@ -33,6 +33,7 @@ export class ConnectionCredentials implements IConnectionInfo {
     public trustServerCertificate: boolean | undefined;
     public hostNameInCertificate: string | undefined;
     public persistSecurityInfo: boolean | undefined;
+    public secureEnclaves: string | undefined;
     public columnEncryptionSetting: string | undefined;
     public attestationProtocol: string | undefined;
     public enclaveAttestationUrl: string | undefined;
@@ -86,6 +87,7 @@ export class ConnectionCredentials implements IConnectionInfo {
             credentials.hostNameInCertificate;
         details.options["persistSecurityInfo"] =
             credentials.persistSecurityInfo;
+        details.options["secureEnclaves"] = credentials.secureEnclaves;
         details.options["columnEncryptionSetting"] =
             credentials.columnEncryptionSetting;
         details.options["attestationProtocol"] =

diff --git a/test/unit/connectionProfile.test.ts b/test/unit/connectionProfile.test.ts
@@ -47,6 +47,7 @@ function createTestCredentials(): IConnectionInfo {
         hostNameInCertificate: "",
         persistSecurityInfo: false,
         columnEncryptionSetting: "Enabled",
+        secureEnclaves: "Enabled",
         attestationProtocol: "HGS",
         enclaveAttestationUrl: "https://attestationurl",
         connectTimeout: 15,

diff --git a/test/unit/perFileConnection.test.ts b/test/unit/perFileConnection.test.ts
@@ -65,6 +65,7 @@ function createTestCredentials(): IConnectionInfo {
         hostNameInCertificate: "",
         persistSecurityInfo: false,
         columnEncryptionSetting: "enabled",
+        secureEnclaves: "Enabled",
         attestationProtocol: "HGS",
         enclaveAttestationUrl: "https://attestationurl",
         connectTimeout: 15,

diff --git a/test/unit/schemaCompareWebViewController.test.ts b/test/unit/schemaCompareWebViewController.test.ts
@@ -169,6 +169,7 @@ suite("SchemaCompareWebViewController Tests", () => {
             hostNameInCertificate: undefined,
             persistSecurityInfo: undefined,
             columnEncryptionSetting: undefined,
+            secureEnclaves: undefined,
             attestationProtocol: undefined,
             enclaveAttestationUrl: undefined,
             commandTimeout: undefined,

diff --git a/typings/vscode-mssql.d.ts b/typings/vscode-mssql.d.ts
@@ -313,6 +313,11 @@ declare module 'vscode-mssql' {
 		 */
 		persistSecurityInfo: boolean | undefined;
 
+		/**
+         * Gets or sets a value that specifies that Always Encrypted with Secure Enclaves is enabled in a connection.
+		 */
+		secureEnclaves: string | undefined;
+
 		/**
 		 * Gets or sets a string value that specifies whether Always Encrypted is enabled or disabled for the connection.
 		 */