-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[date] Add official CMake targets support #8151
Conversation
What's the best way to fix this? https://github.com/HowardHinnant/date/blob/c56f915/include/date/date.h#L139 I'm surprised it's not disabled earlier in the header file. https://github.com/HowardHinnant/date/blob/c56f915/include/date/date.h#L102 I could add a Setting Edit: Talked to Howard. Will submit a PR to the date repo and update this PR if it gets accepted. |
@dan-shaw We have fixed the C++ version detection in The UWP build problem still persists since the library uses C++17 by default (which I find a good idea), but expects the compiler to still support The library defines
Strangely, this only happens when compiling for UWP targets. What would be the appropriate fix for that? I can think of these:
Regarding option 4: I really like that you can overwrite this value in a custom toolchain file. The Is this a known MSVC bug or did I miss something? Edit: I force-pushed option 2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the uwp patch looks fine - just one comment
Thanks for the PR! |
Howard Hinnant added an official CMake script with target exports. Breaking changes:
unofficial::
prefix goes away, but a wrapper script is installed by this port.I suggest removing the wrapper script after a transition period.