Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[date] Fix config.cmake and usage #12739

Merged
merged 3 commits into from
Aug 7, 2020

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Aug 4, 2020

Fixes #12676.

Remove vcpkg-cmake-wrapper and usage because those new targets now provide by official and the unofficial targets are deprecated (added by #8151).

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Aug 4, 2020
@JackBoosY
Copy link
Contributor Author

@acgetchell Could you please test this PR?

Thanks.

@JackBoosY JackBoosY marked this pull request as ready for review August 5, 2020 02:10
@JackBoosY JackBoosY requested a review from PhoebeHui August 5, 2020 02:10
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Aug 6, 2020
@strega-nil strega-nil merged commit 6718a4a into microsoft:master Aug 7, 2020
@JackBoosY JackBoosY deleted the dev/jack/12676 branch August 10, 2020 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[date] build/link failure
3 participants