Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zxing] ZXing library port added. #4854

Merged
merged 6 commits into from
Dec 19, 2018

Conversation

machpavel
Copy link
Contributor

No description provided.

@machpavel machpavel changed the title [zyxing] ZXing library port added. [zxing] ZXing library port added. Nov 29, 2018
@Rastaban Rastaban self-assigned this Dec 4, 2018
@ras0219-msft ras0219-msft assigned ras0219-msft and unassigned Rastaban Dec 5, 2018
@ras0219-msft
Copy link
Contributor

Thanks for the PR!

  1. Since this is a fork of zxing with the repo name zxing-cpp, I renamed the port to better match user expectations.
  2. I looked through the CMake build and I don't see where there is a requirement for opencv[webp]. I've modified the PR to only require core, but could you indicate where the webp requirement comes from?

@machpavel
Copy link
Contributor Author

Hi, thank you for the feedback.

  1. OK, let's leave it like that. I just assumed, that since all libraries in vcpkg are C++, the cpp suffix is redundant...
  2. The need for webp comes from the zxing-cv project; unresolved external symbol errors are thrown otherwise (at least on Ubuntu and GCC)

@ras0219-msft ras0219-msft merged commit d40eb18 into microsoft:master Dec 19, 2018
@PhilLab
Copy link
Contributor

PhilLab commented May 24, 2019

@ras0219-msft Could it be that the renaming zxing -> zxing-cpp led to some errors?

I am using the CMake integration

set(CMAKE_TOOLCHAIN_FILE "D:/DEVELOPMENT/vcpkg/scripts/buildsystems/vcpkg.cmake" CACHE STRING "")

and currently get the CMake error:

CMake Error at D:/DEVELOPMENT/vcpkg/installed/x64-windows/share/zxing/zxing-targets.cmake:80 (message):
  The imported target "zxing::zxing" references the file

     "D:/DEVELOPMENT/vcpkg/installed/x64-windows/tools/zxing-cpp/zxing.exe"

  but this file does not exist.

The slightly different file vcpkg/installed/x64-windows/tools/zxing-cpp/zxing.exe (with the -cpp) does exist.

Additionally, vcpkg\installed\x64-windows\share\zxing-cpp contains the copyright notice while vcpkg\installed\x64-windows\share\zxing contains the cmake scripts (zxing-config.cmake, zxing-targets.cmake, ...)

And the last question: What is the .exe for? Does my application need it as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants