Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zxing-cpp] find_package(zxing) does not work #6616

Closed
ras0219-msft opened this issue May 24, 2019 · 0 comments · Fixed by #6779
Closed

[zxing-cpp] find_package(zxing) does not work #6616

ras0219-msft opened this issue May 24, 2019 · 0 comments · Fixed by #6779
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@ras0219-msft
Copy link
Contributor

From #4854 (comment):

@ras0219-msft Could it be that the renaming zxing -> zxing-cpp led to some errors?

I am using the CMake integration

set(CMAKE_TOOLCHAIN_FILE "D:/DEVELOPMENT/vcpkg/scripts/buildsystems/vcpkg.cmake" CACHE STRING "")
and currently get the CMake error:

CMake Error at D:/DEVELOPMENT/vcpkg/installed/x64-windows/share/zxing/zxing-targets.cmake:80 (message):
The imported target "zxing::zxing" references the file

 "D:/DEVELOPMENT/vcpkg/installed/x64-windows/tools/zxing-cpp/zxing.exe"

but this file does not exist.
The slightly different file vcpkg/installed/x64-windows/tools/zxing-cpp/zxing.exe (with the -cpp) does exist.

Additionally, vcpkg\installed\x64-windows\share\zxing-cpp contains the copyright notice while vcpkg\installed\x64-windows\share\zxing contains the cmake scripts (zxing-config.cmake, zxing-targets.cmake, ...)

And the last question: What is the .exe for? Does my application need it as well?
@ras0219-msft ras0219-msft added the category:port-bug The issue is with a library, which is something the port should already support label May 24, 2019
@PhilLab PhilLab mentioned this issue Jun 5, 2019
Merged
PhilLab added a commit to PhilLab/vcpkg that referenced this issue Jun 6, 2019
@PhilLab
[zxing-cpp] Fixed renaming zxing -> zxing-cpp
82efbbf 
Referenced file
  vcpkg/installed/x64-windows/tools/zxing-cpp/zxing.exe
did not exist, because it was created at
  vcpkg/installed/x64-windows/tools/zxing/zxing.exe

Closes microsoft#6616
Rastaban pushed a commit that referenced this issue Jun 6, 2019
@PhilLab @Rastaban
[zxing-cpp] Fixed renaming zxing -> zxing-cpp (#6779)
4c613a0 
Referenced file
  vcpkg/installed/x64-windows/tools/zxing-cpp/zxing.exe
did not exist, because it was created at
  vcpkg/installed/x64-windows/tools/zxing/zxing.exe

Closes #6616
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[zxing-cpp] Fixed renaming zxing -> zxing-cpp PhilLab/vcpkg
1 participant
@ras0219-msft